ci: Add clang-tidy check for &&, || and ! instead of and, or and not

[paulgessinger]

No description provided.

[codecov]

Codecov Report

Merging #2569 (3f0d9af) into main (fbc3bd8) will decrease coverage by 0.01%.
The diff coverage is 27.72%.

@@            Coverage Diff             @@
##             main    #2569      +/-   ##
==========================================
- Coverage   49.55%   49.54%   -0.01%     
==========================================
  Files         472      472              
  Lines       26724    26719       -5     
  Branches    12318    12313       -5     
==========================================
- Hits        13244    13239       -5     
  Misses       4748     4748              
  Partials     8732     8732              

Files	Coverage Δ
Core/include/Acts/Geometry/CuboidVolumeBounds.hpp	62.06% <100.00%> (ø)
Core/include/Acts/Geometry/Extent.hpp	90.90% <ø> (ø)
...re/include/Acts/Geometry/SurfaceBinningMatcher.hpp	42.85% <100.00%> (ø)
Core/include/Acts/Propagator/AbortList.hpp	83.33% <ø> (ø)
Core/include/Acts/Propagator/ActionList.hpp	100.00% <ø> (ø)
Core/include/Acts/Propagator/DirectNavigator.hpp	75.71% <100.00%> (ø)
...e/include/Acts/Propagator/StepperExtensionList.hpp	64.58% <ø> (ø)
Core/include/Acts/Surfaces/CylinderBounds.hpp	68.75% <100.00%> (ø)
Core/include/Acts/Surfaces/DiamondBounds.hpp	62.50% <100.00%> (ø)
Core/include/Acts/Surfaces/TrapezoidBounds.hpp	73.91% <100.00%> (ø)
... and 106 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊: Physics performance monitoring for 3f0d9af

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[paulgessinger]

Fixes are ready but I want to see the CI fail first.

[benjaminhuth]

But why would we want to forbid and or and not?
I actually like them

[paulgessinger]

As with everything, it's a matter of taste I find it very confusing, and it's bringing one of the worst parts of python syntax to C++.

And the worst imo is having both styles in the same codebase.

At the very least, we should then also switch the rest of the operators, like != to not_eq, & to bitand, | to bitor and ~ to compl. 😆

[andiwand]

I also have a rather strong opinion of not using and / or / not because to me it feels like non-C++

but more importantly I think it should be consistent across the codebase

[paulgessinger]

@andiwand We all have keyboards with keys for punctuation marks nowadays, right? 😅

[benjaminhuth]

@andiwand We all have keyboards with keys for punctuation marks nowadays, right? 😅

Do we? 😆

But I agree, not_eq is terrible indeed. Few years ago I would have said the same about and, or and not but then python came...

However, I actually would argue to keep at least not as alternative to ! because in some cases I think that actually improves readability... If I quickly scan code with

if( !longVariableName )

vs.

if( not longVariableName )

the latter one is better readable I think.

[paulgessinger]

Needed a few more fixes unfortunately, @andiwand.

[acts-project-service]

🔴 Athena integration test results [1f6dd58]

🔴 Some tests have failed!

Please investigate the pipeline!

status	job
🔴	run_workflow_tests_run2_data
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateAmbiguityResolution.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data