-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace magic seeding field in Examples #2577
refactor: Replace magic seeding field in Examples #2577
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2577 +/- ##
=======================================
Coverage 49.63% 49.63%
=======================================
Files 471 471
Lines 26687 26687
Branches 12277 12277
=======================================
Hits 13245 13245
Misses 4746 4746
Partials 8696 8696 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I looked how we introduced this number. First Appearance in Acts seems to be here (pre-PR time): @paulgessinger suggests that the value could be the real ATLAS-field (maybe taken from Athena). |
if I remember correctly @beomki-yeo found a magic number (300) in the seeding implementation which was an approximation for see #2132 |
I am still not sure, how the numbers relate. According to #2132 this relation should make sense
Using |
right that does not add up. I could imagine that this value is the product of some kind of optimization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see, if this changes physics^^
it is only affecting the examples. I updated the ttbar vertexing histograms. they are quite noisy as they are low stat. otherwise it should be uncontroversial and we have one magic number less |
I believe this is not accurate anymore since we switched out the magic number in the seeding
#2132