feat: Add possibility to rotate the trapezoid bounds #2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulgessinger
changed the title
📊: Physics performance monitoring for f8f2ca9physmon summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2583 +/- ##
==========================================
+ Coverage 48.86% 48.87% +0.01%
==========================================
Files 493 493
Lines 29058 29074 +16
Branches 13798 13805 +7
==========================================
+ Hits 14200 14211 +11
Misses 4962 4962
- Partials 9896 9901 +5 ☔ View full report in Codecov by Sentry. |
|
There are some compilation failures here. |
AJPfleger
requested changes
Nov 9, 2023
|
If I'm thinking about this the right way, the bounding box is in surface coordinates, not in bound coordinates, so would have to be rotated as well to capture the underlying trapezoid shape. |
|
I thought in ACTS surface coordinates == bound coordinates? |
rotate vertices get bounding box from convex polygon remove rotation matrix move constructor to cpp
paulgessinger
previously approved these changes
Mar 12, 2024
move more functions to source rotate bounds helper function
AJPfleger
approved these changes
Mar 12, 2024
🔴 Athena integration test results [a606f8a]🔴 Some tests have failed!Please investigate the pipeline! |
acts-project-service
added
the
Fails Athena tests
dimitra97
pushed a commit
to dimitra97/acts
that referenced
this pull request
Mar 19, 2024
Adds the possibility to rotate trapezoid bounds along the center. This is modeled through an additional bounds value `eRotationAngle` which is defaulted to `0` obtaining the original, unrotated trapezoid. Summary - `inside` rotates the incoming surface position into the trapezoid frame which leaves the rest of the code unchanged - the vertex vector is rotated into surface coordinates before returning - the bounding box is adopted in case of a non-zero rotation angle using the `ConvexPolygonBounds` - all implementations are moved to source Co-authored-by: Andreas Stefl <487211+andiwand@users.noreply.github.com>
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
Adds the possibility to rotate trapezoid bounds along the center. This is modeled through an additional bounds value `eRotationAngle` which is defaulted to `0` obtaining the original, unrotated trapezoid. Summary - `inside` rotates the incoming surface position into the trapezoid frame which leaves the rest of the code unchanged - the vertex vector is rotated into surface coordinates before returning - the bounding box is adopted in case of a non-zero rotation angle using the `ConvexPolygonBounds` - all implementations are moved to source Co-authored-by: Andreas Stefl <487211+andiwand@users.noreply.github.com>
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
Adds the possibility to rotate trapezoid bounds along the center. This is modeled through an additional bounds value `eRotationAngle` which is defaulted to `0` obtaining the original, unrotated trapezoid. Summary - `inside` rotates the incoming surface position into the trapezoid frame which leaves the rest of the code unchanged - the vertex vector is rotated into surface coordinates before returning - the bounding box is adopted in case of a non-zero rotation angle using the `ConvexPolygonBounds` - all implementations are moved to source Co-authored-by: Andreas Stefl <487211+andiwand@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the possibility to rotate trapezoid bounds along the center. This is modeled through an additional bounds value
eRotationAnglewhich is defaulted to0obtaining the original, unrotated trapezoid.Summary
insiderotates the incoming surface position into the trapezoid frame which leaves the rest of the code unchangedConvexPolygonBounds