fix: GeoVisualization - Fix compiler warning that's appearing in Athena #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junggjo9
changed the title
📊: Physics performance monitoring for 3912634Full contents |
Codecov Report
@@ Coverage Diff @@
## main #2585 +/- ##
=======================================
Coverage 49.63% 49.63%
=======================================
Files 471 471
Lines 26687 26687
Branches 12277 12277
=======================================
Hits 13245 13245
Misses 4746 4746
Partials 8696 8696
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
paulgessinger
approved these changes
Oct 26, 2023
|
Which compiler did this show up in? I'm a bit surprised this passes our CI here. Maybe we're not configuring the warnings the same way? |
|
I don't know the details of the configuration, it's probably a different warning configuration. |
paulgessinger
pushed a commit
that referenced
this pull request
Oct 26, 2023
…na (#2585) The athena compiler is throwing a warning if the Visualization library is loaded. ``` /var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Tracking/Acts/ActsGeometry/src/SimpleCylinderDetBuilderTool.cxx: In member function 'virtual Acts::Experimental::DetectorComponent ActsTrk::SimpleCylinderDetBuilderTool::construct(const Acts::GeometryContext&) const': /var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Tracking/Acts/ActsGeometry/src/SimpleCylinderDetBuilderTool.cxx:35:53: warning: 'static' expression 'Acts::s_viewSensitive' of type 'Acts::ViewConfig' passed to pointer or reference function argument of 'Acts::GeometryView3D::drawDetectorVolume' within function 'virtual Acts::Experimental::DetectorComponent ActsTrk::SimpleCylinderDetBuilderTool::construct(const Acts::GeometryContext&) const'; may not be thread-safe 35 | Acts::GeometryView3D::drawDetectorVolume(helper, *cylinderDetectorVolume, gctx->context()); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Tracking/Acts/ActsGeometry/src/SimpleCylinderDetBuilderTool.cxx:8: /build/ci-builds/main/Athena/install/AthenaExternals/24.0.15/InstallArea/x86_64-el9-gcc13-opt/include/Acts/Visualization/GeometryView3D.hpp:34:19: note: Declared here: 34 | static ViewConfig s_viewSensitive = ViewConfig({0, 180, 240}); | ^~~~~~~~~~~~~~~ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Tracking/Acts/ActsGeometry/src/SimpleCylinderDetBuilderTool.cxx:35:53: note: See <https://gitlab.cern.ch/atlas/atlasexternals/tree/master/External/CheckerGccPlugins#thread_plugin>. 35 | Acts::GeometryView3D::drawDetectorVolume(helper, *cylinderDetectorVolume, gctx->context()); ``` I hope that's fixing the warning.
acts-project-service
added
the
Fails Athena tests
paulgessinger
removed
the
Fails Athena tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The athena compiler is throwing a warning if the Visualization library is loaded.
I hope that's fixing the warning.