Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve CKF error message if target surface is not reached #2587

Merged

Conversation

andiwand
Copy link
Contributor

After this failure popped up in Athena and was kind of cryptic we wanted to improve the error message

@andiwand andiwand added this to the next milestone Oct 27, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Track Finding labels Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2587 (8f0ba74) into main (825828c) will increase coverage by 0.00%.
The diff coverage is 44.44%.

@@           Coverage Diff           @@
##             main    #2587   +/-   ##
=======================================
  Coverage   49.63%   49.63%           
=======================================
  Files         471      471           
  Lines       26687    26690    +3     
  Branches    12277    12278    +1     
=======================================
+ Hits        13245    13247    +2     
- Misses       4746     4748    +2     
+ Partials     8696     8695    -1     
Files Coverage Δ
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp 32.59% <44.44%> (+0.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit fa3e67e into acts-project:main Oct 27, 2023
53 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Oct 27, 2023
@andiwand andiwand deleted the improve-ckf-target-surface-error-message branch October 27, 2023 20:29
@paulgessinger paulgessinger modified the milestones: next, v31.0.0 Nov 6, 2023
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants