Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add DD4hep field adapter #2593

Merged
merged 10 commits into from
Nov 16, 2023
Merged

feat: Add DD4hep field adapter #2593

merged 10 commits into from
Nov 16, 2023

Conversation

paulgessinger
Copy link
Member

This allows querying the DD4hep-provided magnetic field for our purposes.

You can define a constant field like

<field name="MagnetFields_Constant" type="ConstantField" field="magnetic">
  <strength x="0" y="0" z="2.0*tesla"/>
</field>

or for example a solenoid field like

<field type="solenoid" name="GlobalSolenoid" inner_field="Field_nominal_value"
   outer_field="outerField_nominal_value" zmax="sol_hlength"
   inner_radius="sol_rmin"
   outer_radius="sol_rmax" />

@paulgessinger
feat: Add DD4hep field adapter
119bc29 
This allows querying the DD4hep-provided magnetic field for our
purposes.

You can define a constant field like

```xml
<field name="MagnetFields_Constant" type="ConstantField" field="magnetic">
  <strength x="0" y="0" z="2.0*tesla"/>
</field>
```

or for example a solenoid field like

```xml
<field type="solenoid" name="GlobalSolenoid" inner_field="Field_nominal_value"
   outer_field="outerField_nominal_value" zmax="sol_hlength"
   inner_radius="sol_rmin"
   outer_radius="sol_rmax" />
```
@paulgessinger paulgessinger added this to the next milestone Oct 28, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins labels Oct 28, 2023
@codecov
Copy link

codecov bot commented Oct 28, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (040a896) 49.73% compared to head (2456986) 49.73%.

Files Patch % Lines
Core/src/MagneticField/MagneticFieldError.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2593      +/-   ##
==========================================
- Coverage   49.73%   49.73%   -0.01%     
==========================================
  Files         474      474              
  Lines       26872    26874       +2     
  Branches    12364    12365       +1     
==========================================
  Hits        13366    13366              
- Misses       4702     4704       +2     
  Partials     8804     8804

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 28, 2023 •
edited
Loading

📊: Physics performance monitoring for 2456986

Full contents

physmon summary

@github-actions github-actions bot added the Component - Documentation Affects the documentation label Nov 2, 2023
@github-actions github-actions bot removed the Component - Documentation Affects the documentation label Nov 2, 2023
@asalzburger asalzburger self-requested a review November 14, 2023 16:41
@paulgessinger
Copy link
Member Author

I'll fix the docs failure tomorrow.

@paulgessinger
Copy link
Member Author

paulgessinger commented Nov 15, 2023 •
edited
Loading

Docs failure should be gone now. @asalzburger can you have a look?

@github-actions github-actions bot added the Component - Documentation Affects the documentation label Nov 15, 2023
@kodiakhq kodiakhq bot merged commit ecdbde7 into acts-project:main Nov 16, 2023
49 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [ecdbde7]

🔴 Some tests have failed!

Please investigate the pipeline!

status job
🔴 run_unit_tests
🔴 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🔴 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🔴 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateResolvedTracks.sh
🔴 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🔴 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🔴 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Nov 16, 2023
@paulgessinger paulgessinger modified the milestones: next, v31.0.0 Nov 17, 2023
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalzburger asalzburger asalzburger approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module Component - Documentation Affects the documentation Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins
Projects
None yet
Milestone
v31.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@paulgessinger @acts-project-service @asalzburger @benjaminhuth