Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Intersection index for stepper surface update #2599

Merged
merged 7 commits into from
Nov 2, 2023
Merged

refactor: Intersection index for stepper surface update #2599

merged 7 commits into from
Nov 2, 2023

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Oct 31, 2023 •
edited
Loading

After refactoring the surface intersection #2336 I missed to update this function of the stepper

discovered in #2595 and #2596

@andiwand andiwand added this to the next milestone Oct 31, 2023
@github-actions github-actions bot added the Component - Core Affects the Core module label Oct 31, 2023
This was referenced Oct 31, 2023
Closed
Merged
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Merging #2599 (e9a8249) into main (40f921d) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 45.23%.

❗ Current head e9a8249 differs from pull request most recent head 69baa17. Consider uploading reports for the commit 69baa17 to get more accurate results

@@            Coverage Diff             @@
##             main    #2599      +/-   ##
==========================================
- Coverage   49.53%   49.51%   -0.02%     
==========================================
  Files         472      472              
  Lines       26732    26755      +23     
  Branches    12321    12338      +17     
==========================================
+ Hits        13241    13249       +8     
  Misses       4753     4753              
- Partials     8738     8753      +15
Files Coverage Δ
Core/include/Acts/Propagator/AtlasStepper.hpp 72.15% <100.00%> (ø)
Core/include/Acts/Propagator/EigenStepper.hpp 80.00% <100.00%> (ø)
...re/include/Acts/Propagator/StraightLineStepper.hpp 74.28% <100.00%> (ø)
.../include/Acts/Propagator/MultiEigenStepperLoop.hpp 69.02% <50.00%> (ø)
Core/include/Acts/Navigation/DetectorNavigator.hpp 51.44% <33.33%> (+0.35%) ⬆️
.../include/Acts/Propagator/detail/SteppingHelper.hpp 57.14% <33.33%> (+4.96%) ⬆️
Core/include/Acts/Propagator/DirectNavigator.hpp 65.04% <46.66%> (-1.22%) ⬇️
Core/include/Acts/Propagator/Navigator.hpp 57.22% <38.46%> (+0.14%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

📊: Physics performance monitoring for 69baa17

Full contents

physmon summary

@andiwand andiwand mentioned this pull request Oct 31, 2023
Closed
@andiwand @paulgessinger
Apply suggestions from code review
e9a8249 
Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
@paulgessinger
Copy link
Member

Docs build should be fixed in #2613.

@kodiakhq kodiakhq bot merged commit 3fd6166 into acts-project:main Nov 2, 2023
54 checks passed
@github-actions github-actions bot removed the automerge label Nov 2, 2023
@andiwand andiwand deleted the refactor-stepper-surface-update-index branch November 2, 2023 13:28
@acts-project-service
Copy link
Collaborator

acts-project-service commented Nov 2, 2023 •
edited
Loading

✅ Athena integration test results [3fd6166]

✅ All tests successful

status job
🟢 run_unit_tests
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateAmbiguityResolution.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data

@paulgessinger paulgessinger modified the milestones: next, v31.0.0 Nov 6, 2023
kodiakhq bot pushed a commit that referenced this pull request Nov 21, 2023
@andiwand
refactor: Release step constraint after stepper in propagation (#2596)
37a2f9e 
This avoids cases where an actor/aborter sets a step constrained that will never be overwritten again.

I also generalize the `release` function and rename the `set` function in the stepper.

blocked by
- #2599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module
Projects
None yet
Milestone
v31.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@andiwand @paulgessinger @acts-project-service