Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to newer podio versions #2606

Merged
merged 10 commits into from
Nov 22, 2023

Conversation

asalzburger
Copy link
Contributor

This PR has a small modification to access the index of podio::ObjectID directly, and thus makes ACTS compatible with newer podio versions.

@asalzburger asalzburger added this to the next milestone Nov 1, 2023
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Nov 1, 2023
paulgessinger
paulgessinger previously approved these changes Nov 1, 2023
@paulgessinger
Copy link
Member

Seems like this is not backward compatible. We can either

  1. Bump the minimum required podio/edm4hep version
  2. Add a helper function that checks the object id type using std::is_same_v and returns either the id itself or the index member.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3639e04) 49.53% compared to head (2b0f0eb) 49.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2606   +/-   ##
=======================================
  Coverage   49.53%   49.53%           
=======================================
  Files         474      474           
  Lines       26944    26944           
  Branches    12435    12435           
=======================================
  Hits        13348    13348           
  Misses       4751     4751           
  Partials     8845     8845           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andiwand
andiwand previously approved these changes Nov 21, 2023
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look fine to me but build is still failing

@paulgessinger
Copy link
Member

changes look fine to me but build is still failing

Ah of course, because we don't have that version in the CI. I should use my brain.

@paulgessinger
Copy link
Member

Ok, let's try the other thing where it tries to figure out what comes from .id().

@kodiakhq kodiakhq bot merged commit 60ff980 into acts-project:main Nov 22, 2023
51 checks passed
@acts-project-service
Copy link
Collaborator

@paulgessinger paulgessinger modified the milestones: next, v31.1.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants