-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to newer podio versions #2606
chore: update to newer podio versions #2606
Conversation
Seems like this is not backward compatible. We can either
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2606 +/- ##
=======================================
Coverage 49.53% 49.53%
=======================================
Files 474 474
Lines 26944 26944
Branches 12435 12435
=======================================
Hits 13348 13348
Misses 4751 4751
Partials 8845 8845 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look fine to me but build is still failing
Ah of course, because we don't have that version in the CI. I should use my brain. |
This reverts commit 7e6f3ce.
Ok, let's try the other thing where it tries to figure out what comes from |
This PR has a small modification to access the index of
podio::ObjectID
directly, and thus makes ACTS compatible with newerpodio
versions.