-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow custom precision for volume grid building #2609
feat: allow custom precision for volume grid building #2609
Conversation
Fails unit test at the moment. |
Codecov Report
@@ Coverage Diff @@
## main #2609 +/- ##
=======================================
Coverage 49.60% 49.60%
=======================================
Files 473 473
Lines 26828 26833 +5
Branches 12355 12357 +2
=======================================
+ Hits 13308 13311 +3
Misses 4753 4753
- Partials 8767 8769 +2
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Hey @niermann999 - this is a PR that allows to catch for numerical instabilities in the volume grid. |
Ping @niermann999 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this had slipped my mind. What issue did it fix?
Core/include/Acts/Detector/detail/CylindricalDetectorHelper.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Joana Niermann <53186085+niermann999@users.noreply.github.com>
Invalidated by push of 26e8b44
It makes rounded values for common boundaries and hence avoid that the |
This PR allows to set some numerical precision for the volume grid binning, which removes some odd cases when writing out to Json and reading into Detray.