Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Put some helper types for Loop-Multistepper into separate file #2612

Merged

Conversation

benjaminhuth
Copy link
Member

self explaining.

@benjaminhuth benjaminhuth added this to the next milestone Nov 1, 2023
@benjaminhuth benjaminhuth requested a review from andiwand November 1, 2023 22:38
@github-actions github-actions bot added the Component - Core Affects the Core module label Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #2612 (9732f95) into main (76cf010) will decrease coverage by 0.01%.
The diff coverage is 94.28%.

❗ Current head 9732f95 differs from pull request most recent head 9535001. Consider uploading reports for the commit 9535001 to get more accurate results

@@            Coverage Diff             @@
##             main    #2612      +/-   ##
==========================================
- Coverage   49.52%   49.51%   -0.01%     
==========================================
  Files         472      473       +1     
  Lines       26756    26755       -1     
  Branches    12338    12338              
==========================================
- Hits        13250    13249       -1     
  Misses       4753     4753              
  Partials     8753     8753              
Files Coverage Δ
.../include/Acts/Propagator/MultiEigenStepperLoop.hpp 63.08% <ø> (-5.94%) ⬇️
.../include/Acts/Propagator/MultiEigenStepperLoop.ipp 41.74% <ø> (ø)
...nclude/Acts/Propagator/detail/LoopStepperUtils.hpp 94.28% <94.28%> (ø)

... and 6 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@kodiakhq kodiakhq bot merged commit 4571a6b into acts-project:main Nov 3, 2023
52 checks passed
@github-actions github-actions bot removed the automerge label Nov 3, 2023
@paulgessinger paulgessinger modified the milestones: next, v31.0.0 Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants