refactor!: Move Grid out of detail
#2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of the public API (and documented to some degree) so shouldn't be in `detail`.
AJPfleger
previously approved these changes
Nov 2, 2023
github-actions
bot
added
Component - Core
acts-policybot
bot
dismissed
AJPfleger’s stale review
Invalidated by push of be4c79a
AJPfleger
approved these changes
Nov 2, 2023
Codecov Report
@@ Coverage Diff @@
## main #2616 +/- ##
=======================================
Coverage 49.51% 49.52%
=======================================
Files 472 472
Lines 26755 26756 +1
Branches 12338 12338
=======================================
+ Hits 13249 13250 +1
Misses 4753 4753
Partials 8753 8753
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
1 task
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
This PR rationalizes the documentation a bit. The main points are - Remove the documentation of the old standalone examples executables - Restructure the core documentation to be less sprawling - Move the figures from a central folder closer to the relevant source files - Remove the full auto API documentation in favor of a combination of hard-coded documented symbols + an auto detection mechanism to catch when we references symbols somewhere - This reduces the time it takes to build the docs drastically - Enable nitpicky generation, which will warn (and fail) if symbols are references that don't have a target. - [x] Try to auto-generate API listings only for the elements we explicitly call out by class / func roles. Blocked by: - #2616 - #2617 - #2624
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the public API (and documented to some degree) so shouldn't be in
detail.