feat: Introduce propagator stage #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
commented
Nov 3, 2023
Codecov Report
@@ Coverage Diff @@
## main #2621 +/- ##
=======================================
Coverage 49.59% 49.60%
=======================================
Files 473 473
Lines 26824 26828 +4
Branches 12355 12355
=======================================
+ Hits 13304 13308 +4
Misses 4753 4753
Partials 8767 8767
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
benjaminhuth
approved these changes
Nov 7, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
With these changes I try to decouple the navigator and surface reached aborter further. I don't believe that the navigator has to care about the target surface other than optimization reasons while the surface reached aborter should only care about the surface it is supposed to care about without looking at or touching the navigation state. blocked by - #2621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to discover in which stage of propagation we are in the actors and aborters. By introducing a propagator stage enum, adding it to the state and setting it in the proagator loop this can be used in the actors and aborters.
Pulled out of #2603