Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Wire Geant4MaterialRecording exclude material to python #2628

Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Nov 3, 2023

No description provided.

@andiwand andiwand added this to the next milestone Nov 3, 2023
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2628 (83bbad5) into main (c578923) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 26.00%.

@@           Coverage Diff           @@
##             main    #2628   +/-   ##
=======================================
  Coverage   49.50%   49.50%           
=======================================
  Files         473      473           
  Lines       26746    26770   +24     
  Branches    12338    12349   +11     
=======================================
+ Hits        13240    13253   +13     
- Misses       4753     4754    +1     
- Partials     8753     8763   +10     
Files Coverage Δ
Core/include/Acts/Geometry/Layer.hpp 100.00% <ø> (ø)
Core/include/Acts/Geometry/NavigationLayer.hpp 84.61% <ø> (ø)
Core/include/Acts/Navigation/DetectorNavigator.hpp 52.14% <100.00%> (+0.69%) ⬆️
...include/Acts/Navigation/NavigationStateFillers.hpp 85.71% <ø> (ø)
Core/include/Acts/Surfaces/BoundaryCheck.hpp 48.14% <ø> (ø)
Core/include/Acts/Surfaces/ConeBounds.hpp 71.42% <ø> (ø)
Core/include/Acts/Surfaces/ConeSurface.hpp 100.00% <ø> (ø)
Core/include/Acts/Surfaces/CylinderBounds.hpp 68.75% <ø> (ø)
Core/include/Acts/Surfaces/CylinderSurface.hpp 100.00% <ø> (ø)
Core/include/Acts/Surfaces/DiscSurface.hpp 100.00% <ø> (ø)
... and 21 more

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@kodiakhq kodiakhq bot merged commit ee82495 into acts-project:main Nov 4, 2023
53 checks passed
@github-actions github-actions bot removed the automerge label Nov 4, 2023
@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Nov 4, 2023
@andiwand andiwand deleted the python-bind-g4-material-exclude branch November 5, 2023 09:04
@paulgessinger paulgessinger modified the milestones: next, v31.0.0 Nov 6, 2023
@paulgessinger paulgessinger removed the Breaks Athena build This PR breaks the Athena build label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants