-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Update to gcovr=6.0 and remove bundled-version support #2629
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2629 +/- ##
==========================================
+ Coverage 49.50% 49.57% +0.06%
==========================================
Files 473 473
Lines 26770 26803 +33
Branches 12349 12349
==========================================
+ Hits 13253 13288 +35
+ Misses 4754 4752 -2
Partials 8763 8763 see 25 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
The |
it should be. I am rewriting the test, since we do not have the |
@paulgessinger , it seems to work now. The total coverage still changes a bit, but the flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the slight coverage change is acceptable.
Addresses and closes Issue #1211
The supposed problem was "Parallel processing of gcov data. (#%s592)" in gcov 5.1. This was already fixed in 5.2.
We need to add
--exclude-noncode-lines
due to a breaking change in gcovr 6.0, otherwise our coverage would change a lot (-0.33%):New --exclude-noncode-lines to exclude noncode lines. Noncode lines are not excluded by default anymore. (#%s704, #%s705)
Closes #1211
Update the gcovr-call
/Legacy/
v5.0
v5.1
is used