Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update to gcovr=6.0 and remove bundled-version support #2629

Merged
merged 7 commits into from
Nov 5, 2023

Conversation

AJPfleger
Copy link
Contributor

@AJPfleger AJPfleger commented Nov 3, 2023

Addresses and closes Issue #1211

The supposed problem was "Parallel processing of gcov data. (#%s592)" in gcov 5.1. This was already fixed in 5.2.

We need to add --exclude-noncode-lines due to a breaking change in gcovr 6.0, otherwise our coverage would change a lot (-0.33%):
New --exclude-noncode-lines to exclude noncode lines. Noncode lines are not excluded by default anymore. (#%s704, #%s705)

Closes #1211

Update the gcovr-call

  • remove use of local bundled version (files were removed some years ago)
  • remove outdated exclude of folder /Legacy/
  • remind user to update gcovr to at least v5.0
  • assert if v5.1 is used
  • black

@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2629 (b8311bb) into main (ee82495) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2629      +/-   ##
==========================================
+ Coverage   49.50%   49.57%   +0.06%     
==========================================
  Files         473      473              
  Lines       26770    26803      +33     
  Branches    12349    12349              
==========================================
+ Hits        13253    13288      +35     
+ Misses       4754     4752       -2     
  Partials     8763     8763              

see 25 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@paulgessinger
Copy link
Member

paulgessinger commented Nov 4, 2023

The --exclude-noncode-lines does not seem to be present in gcovr 6.0?

@AJPfleger
Copy link
Contributor Author

AJPfleger commented Nov 4, 2023

it should be. I am rewriting the test, since we do not have the cmake/gcovr backup in case no gcovr is installed. give me a few minutes, I am about to finish ;)

@AJPfleger AJPfleger changed the title ci: Update to gcovr=6.0 ci: Update to gcovr=6.0 and remove bundled-version support Nov 4, 2023
@AJPfleger AJPfleger marked this pull request as ready for review November 4, 2023 11:45
@AJPfleger
Copy link
Contributor Author

@paulgessinger , it seems to work now. The total coverage still changes a bit, but the flag --exclude-noncode-lines now reduces the new "hits" by 80%. I couldn't find any other breaking changes, in gcovr, that explain the updated coverage. I would now go with the newer version.

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the slight coverage change is acceptable.

@kodiakhq kodiakhq bot merged commit f185bad into acts-project:main Nov 5, 2023
53 checks passed
@github-actions github-actions bot removed the automerge label Nov 5, 2023
@AJPfleger AJPfleger deleted the gcovr branch November 5, 2023 16:05
@paulgessinger paulgessinger modified the milestones: next, v31.0.0 Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Coverage job is broken with gcovr >= 5.1
3 participants