fix: and refactor geometric digitization

[benjaminhuth]

• fix: activation was only 2D path, but must be 3D path. Otherwise, an upright track would get 0 activation...
• refactor: rename Channelizer to Segmentizer, add Channelizer that ties together the things
• added unit test

[codecov]

Codecov Report

Merging #2630 (e2d36bd) into main (85a0fea) will not change coverage.
The diff coverage is n/a.

❗ Current head e2d36bd differs from pull request most recent head 7acfdf9. Consider uploading reports for the commit 7acfdf9 to get more accurate results

@@           Coverage Diff           @@
##             main    #2630   +/-   ##
=======================================
  Coverage   49.71%   49.71%           
=======================================
  Files         474      474           
  Lines       26859    26859           
  Branches    12362    12362           
=======================================
  Hits        13352    13352           
  Misses       4706     4706           
  Partials     8801     8801           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

[asalzburger]

Unit test is failing - is that expected ? Do we need to update the test?

[benjaminhuth]

Hmm no is not expected. They should run through. I will check after the workshop

[AJPfleger]

Could you also adapt the tests to what I did in #2632 ? :)

I didn't touch Tests/UnitTests/Fatras/Digitization/ChannelizerTests.cpp in my PR to avoid conflicts on your side.
Also the file Tests/UnitTests/Fatras/Digitization/SegmentizerTests.cpp will be new for me.

[asalzburger]

Makes sense, let's fix the UnitTests and get that in.

[github-actions]

📊: Physics performance monitoring for 7acfdf9

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[benjaminhuth]

@asalzburger The PR should now be ready, can you approve?

[acts-project-service]

🔴 Athena integration test results

Build job with this PR failed!

Please investigate the build job for the pipeline!