Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update physmon vertexing histogram ranges #2638

Merged
merged 6 commits into from
Nov 8, 2023

Conversation

felix-russo
Copy link
Contributor

@felix-russo felix-russo commented Nov 6, 2023

Reconfigure some histogram ranges in the vertexing CI

@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Nov 6, 2023
@felix-russo felix-russo marked this pull request as ready for review November 6, 2023 20:00
@felix-russo felix-russo changed the title refactor: update histo ranges ci: update histogram ranges Nov 6, 2023
@paulgessinger paulgessinger changed the title ci: update histogram ranges ci: Update physmon vertexing histogram ranges Nov 7, 2023
@paulgessinger paulgessinger added this to the next milestone Nov 7, 2023
@paulgessinger
Copy link
Member

paulgessinger commented Nov 7, 2023

Physmon failures are expected after range changes. Can you update the references?

res_t still looks weirdly flat, is this expected?

image

EDIT: Nervmind, I think what was AMVF.

IVF looks like this and much better:

image

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #2638 (1f88802) into main (ce35608) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2638   +/-   ##
=======================================
  Coverage   49.60%   49.60%           
=======================================
  Files         473      473           
  Lines       26828    26828           
  Branches    12355    12355           
=======================================
  Hits        13308    13308           
  Misses       4753     4753           
  Partials     8767     8767           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@felix-russo
Copy link
Contributor Author

References are updated! @paulgessinger

@kodiakhq kodiakhq bot merged commit de6b940 into acts-project:main Nov 8, 2023
53 checks passed
@github-actions github-actions bot removed the automerge label Nov 8, 2023
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Nov 8, 2023
@felix-russo felix-russo deleted the resT-histo-width branch November 8, 2023 14:59
@paulgessinger paulgessinger modified the milestones: next, v31.0.0 Nov 15, 2023
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants