refactor: Move common test helpers to core

[tboldagh]

This PR moves MultiTrajectory test helpers to the Core package. Thanks to that we would be able to reuse them in ATLAS to setup the compatible test. Once changes in MTJ implemenation in ACTS change it would be reflected in the test and during integration of that change the shared test will indicate what exacly needs to be updated.

@paulgessinger @CarloVarni - since you two discussed that a bit @ workshop please let me know if this is the right direction. As you see I have left out thet TestTrackProxy and TestSourceLink in order minimize polution of Core package.

[paulgessinger]

I think this is it! Thanks @tboldagh

[tboldagh]

@paulgessinger - would moving GenerateParameters.h to Core be still ok?

[codecov]

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (0fe485d) 49.48% compared to head (149690d) 48.68%.

❗ Current head 149690d differs from pull request most recent head 2a4d294. Consider uploading reports for the commit 2a4d294 to get more accurate results

Files	Patch %	Lines
...e/include/Acts/EventData/detail/TestSourceLink.hpp	62.50%	1 Missing and 5 partials ⚠️
...ts/EventData/detail/MultiTrajectoryTestsCommon.hpp	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2645      +/-   ##
==========================================
- Coverage   49.48%   48.68%   -0.81%     
==========================================
  Files         474      478       +4     
  Lines       27075    27888     +813     
  Branches    12516    13172     +656     
==========================================
+ Hits        13399    13578     +179     
- Misses       4762     4765       +3     
- Partials     8914     9545     +631     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📊: Physics performance monitoring for 2a4d294

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles fatras
• ✅ Particles geant4

[tboldagh]

I am not able to reproduce the compilation error enabling these: -DACTS_BUILD_EVERYTHING=ON ACTS_BUILD_PLUGIN_PODIO=ON

Any hint is welcome.

[tboldagh]

Hmm, the test coverage is smaller. But how is that possible after just moving code around?
Can it be that because TestSourceLink has not some more of the code in the header it needs to be checked?

[paulgessinger]

@tboldagh The coverage calculation is not 100% robust. If it's a small change and we don't think it's damaging, we can ignore it.

[paulgessinger]

Changes overall look clean. What do you think about putting the files into a subfolder detail_test to indicate they're not really meant for public consumption?

[paulgessinger]

@tboldagh looks good to me, only the format needs a quick fix, then we can merge this!

[acts-project-service]

✅ Athena integration test results [b533a87]

✅ All tests successful

status	job
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateAmbiguityResolution.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateResolvedTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsGSFRefitting.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco