refactor: Refactor RootTrackStatesWriter

[andiwand]

• simplify code
• remove magic -99 value
• write non measurement states

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a01f82a) 49.71% compared to head (42f24b3) 49.71%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2648   +/-   ##
=======================================
  Coverage   49.71%   49.71%           
=======================================
  Files         474      474           
  Lines       26859    26859           
  Branches    12362    12362           
=======================================
  Hits        13352    13352           
  Misses       4706     4706           
  Partials     8801     8801           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📊: Physics performance monitoring for 42f24b3

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[paulgessinger]

I think there's an FPE in one of the physmon jobs. Would you be able to look into this @benjaminhuth?

[asalzburger]

Could you do the change to momentum() from track state already here, then this would be complete ...

[andiwand]

I think there's an FPE in one of the physmon jobs. Would you be able to look into this @benjaminhuth?

did you mean to tag me? which FPE is this?

[benjaminhuth]

Good to clear this up. Just a few comments, and a general question:

Don't we have to ensure that the vectors in the TTree have all the same lengths, so that everything stays consistent? Or is there some magic going on in ROOT?

[benjaminhuth]

Looks good, only one stylistic thing came to my mind, but feel free to ignore it!

[benjaminhuth]

Looks good!

[acts-project-service]

🔴 Athena integration test results [cc29c08]

🔴 Some tests have failed!

Please investigate the pipeline!

status	job
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🔴	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateAmbiguityResolution.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🔴	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data