fix: newVertex not considered in AdaptiveMultiVertexFit

[felix-russo]

I found out that the fit is sometimes called with an empty vertexCollection. Upon investigation, I realized that, when we call the function addVtxToFit, we only fit all vertices that share tracks with newVertex - but not newVertex itself. If newVertex is not connected to any tracks, then we execute the fit for 0 vertices. This PR makes sure that newVertex is always fit:

This PR further removes the redundant fit function and renames fitImpl -> fit

[github-actions]

📊: Physics performance monitoring for 4b9fd88

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[codecov]

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (1c81427) 49.73% compared to head (4b9fd88) 49.72%.

Files	Patch %	Lines
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.hpp	28.57%	2 Missing and 3 partials ⚠️
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.ipp	42.85%	1 Missing and 3 partials ⚠️
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.ipp	0.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2655      +/-   ##
==========================================
- Coverage   49.73%   49.72%   -0.02%     
==========================================
  Files         474      474              
  Lines       26874    26880       +6     
  Branches    12365    12370       +5     
==========================================
  Hits        13366    13366              
- Misses       4704     4706       +2     
- Partials     8804     8808       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[felix-russo]

I guess the physmon is not failing because the vertex is included eventually when more vertices are added that share tracks with it

[acts-project-service]

🔴 Athena integration test results [af8a537]

🔴 Some tests have failed!

Please investigate the pipeline!

status	job
🔴	run_unit_tests
🔴	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🔴	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🔴	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateResolvedTracks.sh
🔴	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🔴	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🔴	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data