Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce typelist #2656

Merged
merged 11 commits into from
Nov 14, 2023

Conversation

asalzburger
Copy link
Contributor

This PR introduces a minimal implementation of a C++ typelist to be used many in grid I/O (Json/Svg) in order to allow casting to a dedicated grid type.

It follows relatively closely to what @niermann999 has done for detray, but omits the at[index] access as it aims to allow type iteration and not individual type casting.

@asalzburger asalzburger added this to the next milestone Nov 13, 2023
@github-actions github-actions bot added the Component - Core Affects the Core module label Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (478abb0) 49.72% compared to head (63cbb8a) 49.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2656   +/-   ##
=======================================
  Coverage   49.72%   49.72%           
=======================================
  Files         474      474           
  Lines       26863    26863           
  Branches    12363    12363           
=======================================
  Hits        13357    13357           
  Misses       4704     4704           
  Partials     8802     8802           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good.

  • can you change the detail namespace name something more unique, since the functions themselves have fairly generic names.
  • equivalently for the typedefs, they have very generic names like front, which we might want to avoid having in the global detail namespace. In the EDM work I went with detail_xyz to scope the types.
  • we could consider even putting the TypeList type and manipulator functions in the main Acts namespace.

I think this can also be done in a follow-up PR.

asalzburger and others added 4 commits November 14, 2023 11:12
Co-authored-by: Joana Niermann <53186085+niermann999@users.noreply.github.com>
Co-authored-by: Joana Niermann <53186085+niermann999@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Remove unused tuple include
niermann999
niermann999 previously approved these changes Nov 14, 2023
@asalzburger
Copy link
Contributor Author

Hi, I should have addressed the first set of comments.

@kodiakhq kodiakhq bot merged commit 6352ad8 into acts-project:main Nov 14, 2023
55 checks passed
@asalzburger asalzburger deleted the feat-introduce-typelist branch November 14, 2023 14:06
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Nov 14, 2023
@paulgessinger paulgessinger modified the milestones: next, v31.0.0 Nov 15, 2023
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Nov 16, 2023
kodiakhq bot pushed a commit that referenced this pull request Dec 6, 2023
…2750)

This makes sense for code deduplication, and after #2656 was merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants