-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce typelist #2656
feat: introduce typelist #2656
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2656 +/- ##
=======================================
Coverage 49.72% 49.72%
=======================================
Files 474 474
Lines 26863 26863
Branches 12363 12363
=======================================
Hits 13357 13357
Misses 4704 4704
Partials 8802 8802 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good.
- can you change the detail namespace name something more unique, since the functions themselves have fairly generic names.
- equivalently for the typedefs, they have very generic names like
front
, which we might want to avoid having in the global detail namespace. In the EDM work I went withdetail_xyz
to scope the types. - we could consider even putting the
TypeList
type and manipulator functions in the mainActs
namespace.
I think this can also be done in a follow-up PR.
Co-authored-by: Joana Niermann <53186085+niermann999@users.noreply.github.com>
Co-authored-by: Joana Niermann <53186085+niermann999@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Remove unused tuple include
Invalidated by push of 7bd5891
Hi, I should have addressed the first set of comments. |
This PR introduces a minimal implementation of a C++ typelist to be used many in grid I/O (Json/Svg) in order to allow casting to a dedicated grid type.
It follows relatively closely to what @niermann999 has done for detray, but omits the
at[index]
access as it aims to allow type iteration and not individual type casting.