docs: Add a white paper for line surface jacobian #2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beomki-yeo
force-pushed
the
white-paper-1
branch
from
326265e to
a01f82a
Compare
📊: Physics performance monitoring for 7f5d4c2physmon summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2657 +/- ##
=======================================
Coverage 48.62% 48.62%
=======================================
Files 480 480
Lines 28033 28033
Branches 13263 13263
=======================================
Hits 13630 13630
Misses 4803 4803
Partials 9600 9600 ☔ View full report in Codecov by Sentry. |
andiwand
reviewed
Nov 13, 2023
docs/white_papers/figures/correction-for-transport-jacobian.png
Outdated
Show resolved
Hide resolved
beomki-yeo
force-pushed
the
white-paper-1
branch
2 times, most recently
from
67a14a1 to
356ce99
Compare
|
Sorry, this got held up unfortunately. @beomki-yeo, could you fix the conflict? |
|
Of course. Meanwhile, I figured out the rest of calculations so I will update with it. |
beomki-yeo
force-pushed
the
white-paper-1
branch
from
6093a75 to
8e51b93
Compare
|
I guess it is good to go now |
|
@andiwand @paulgessinger Any review on this? |
beomki-yeo
force-pushed
the
white-paper-1
branch
from
8e51b93 to
9783b9e
Compare
andiwand
previously approved these changes
Dec 12, 2023
|
sorry I just took a quick look and I have a few comments but no need to implement this right away
|
|
Thanks I will modify the manuscript except this:
It's super painful to write a full matrix representation, and it is not very necessary I suppose |
beomki-yeo
force-pushed
the
white-paper-1
branch
3 times, most recently
from
5b985cd to
3dbf7fb
Compare
|
@paulgessinger @andiwand can you merge this? |
andiwand
previously approved these changes
Dec 13, 2023
beomki-yeo
force-pushed
the
white-paper-1
branch
from
3dbf7fb to
b9a81fc
Compare
acts-policybot
bot
dismissed
andiwand’s stale review
Invalidated by push of b9a81fc
paulgessinger
approved these changes
Dec 13, 2023
|
This got hung up again :/ Shouldn't we have to reduce the threads in gitlab CI as we did for traccc? |
|
The job that fails is the most important one, and it's because of OOM. I think we increased our build memory consumption again in the recent weeks. |
acts-project-service
added
the
Breaks Athena build
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
This PR adds a white paper for line surface jacobian Abstract: ``` Line surface used for wire measurements or perigee surface is an unique type of surface where the intersections of a track is not defined on a physical plane. Due to this trait, the underlying mathematics gets quite complicated especially with coordinate transform jacobian. In this white paper, we attempt to derive the jacobians for both of local-to-global and global-to-local transforms. ``` ~~The whitepaper contains the calculation of local-to-global transformation jacobian but it doesn't include global-to-local one, which I left for future authors (I didn't manage to solve it)~~ Update: global to local jacobian calculation is updated. Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a white paper for line surface jacobian
Abstract:
The whitepaper contains the calculation of local-to-global transformation jacobian but it doesn't include global-to-local one, which I left for future authors (I didn't manage to solve it)Update: global to local jacobian calculation is updated.