-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Consistent naming of GSF mixture reduction and component merging #2658
Merged
kodiakhq
merged 3 commits into
acts-project:main
from
benjaminhuth:refactor/clean-merging-reduction
Nov 14, 2023
Merged
refactor!: Consistent naming of GSF mixture reduction and component merging #2658
kodiakhq
merged 3 commits into
acts-project:main
from
benjaminhuth:refactor/clean-merging-reduction
Nov 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Track Fitting
labels
Nov 13, 2023
benjaminhuth
changed the title
refactor!: Cleanup naming of GSF mixture reduction and component merging
refactor!: Consistent naming of GSF mixture reduction and component merging
Nov 13, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2658 +/- ##
=======================================
Coverage 49.71% 49.71%
=======================================
Files 474 474
Lines 26859 26859
Branches 12362 12362
=======================================
Hits 13352 13352
Misses 4706 4706
Partials 8801 8801 ☔ View full report in Codecov by Sentry. |
andiwand
approved these changes
Nov 13, 2023
acts-project-service
added
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Nov 14, 2023
paulgessinger
removed
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Core
Affects the Core module
Component - Documentation
Affects the documentation
Component - Examples
Affects the Examples module
Track Fitting
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies consistent naming for two similar operations on Gaussian mixtures: