Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Consistent naming of GSF mixture reduction and component merging #2658

Merged

Conversation

benjaminhuth
Copy link
Member

This PR applies consistent naming for two similar operations on Gaussian mixtures:

  • component merging is the procedure of merge Gaussian components to a single set of parameters+covariance
  • mixture reduction is reducing the number of components in a mixture

@benjaminhuth benjaminhuth added this to the v31.0.0 milestone Nov 13, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Track Fitting labels Nov 13, 2023
@benjaminhuth benjaminhuth changed the title refactor!: Cleanup naming of GSF mixture reduction and component merging refactor!: Consistent naming of GSF mixture reduction and component merging Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cc29c08) 49.71% compared to head (f3d3855) 49.71%.

Files Patch % Lines
...re/include/Acts/TrackFitting/GaussianSumFitter.hpp 50.00% 0 Missing and 1 partial ⚠️
Core/include/Acts/TrackFitting/detail/GsfActor.hpp 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2658   +/-   ##
=======================================
  Coverage   49.71%   49.71%           
=======================================
  Files         474      474           
  Lines       26859    26859           
  Branches    12362    12362           
=======================================
  Hits        13352    13352           
  Misses       4706     4706           
  Partials     8801     8801           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 6e8cd68 into acts-project:main Nov 14, 2023
53 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Nov 14, 2023
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Documentation Affects the documentation Component - Examples Affects the Examples module Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants