Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: messages: fix missing and wrong closing ticks ' #2663

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

AJPfleger
Copy link
Contributor

No description provided.

@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins labels Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (fbfd389) 49.73% compared to head (00015ee) 49.73%.

Files Patch % Lines
.../src/Detector/detail/CylindricalDetectorHelper.cpp 0.00% 1 Missing and 2 partials ⚠️
Core/src/Geometry/CylinderVolumeHelper.cpp 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2663   +/-   ##
=======================================
  Coverage   49.73%   49.73%           
=======================================
  Files         474      474           
  Lines       26872    26872           
  Branches    12364    12364           
=======================================
  Hits        13366    13366           
  Misses       4702     4702           
  Partials     8804     8804           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulgessinger paulgessinger added this to the v31.0.0 milestone Nov 15, 2023
@asalzburger asalzburger merged commit ebb7d40 into acts-project:main Nov 16, 2023
54 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [ebb7d40]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Nov 16, 2023
@AJPfleger AJPfleger deleted the closingticks branch November 16, 2023 06:43
@paulgessinger paulgessinger removed the Breaks Athena build This PR breaks the Athena build label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants