-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add nUpdatesGx2f
to RootTrackSummaryWriter
#2665
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2665 +/- ##
=======================================
Coverage 49.52% 49.52%
=======================================
Files 474 474
Lines 26968 26968
Branches 12452 12452
=======================================
Hits 13355 13355
Misses 4755 4755
Partials 8858 8858 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
This PR currently has a merge conflict. Please resolve this and then re-add the |
can you resolve the conflict @AJPfleger ? |
@AJPfleger You could also add an option to the writer to avoid changes in the unrelated outputs (see https://github.com/benjaminhuth/acts/blob/478bde937ccffb6b3b4cf51be3c765ed040b3743/Examples/Io/Root/include/ActsExamples/Io/Root/RootTrackSummaryWriter.hpp#L71) (sorry for this late comment, you can also ignore it if everything is in place already) |
This PR currently has a merge conflict. Please resolve this and then re-add the |
This picked up a merge conflict now, which you'd have to manually resolve @AJPfleger. |
We discussed on adding also fitter-specific columns to the root-writer.