Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add nUpdatesGx2f to RootTrackSummaryWriter #2665

Merged
merged 19 commits into from
Nov 22, 2023

Conversation

AJPfleger
Copy link
Contributor

@AJPfleger AJPfleger commented Nov 14, 2023

We discussed on adding also fitter-specific columns to the root-writer.

@github-actions github-actions bot added the Component - Examples Affects the Examples module label Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a560e7c) 49.52% compared to head (db1956b) 49.52%.

Files Patch % Lines
...nclude/Acts/TrackFitting/GlobalChiSquareFitter.hpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2665   +/-   ##
=======================================
  Coverage   49.52%   49.52%           
=======================================
  Files         474      474           
  Lines       26968    26968           
  Branches    12452    12452           
=======================================
  Hits        13355    13355           
  Misses       4755     4755           
  Partials     8858     8858           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Changes Performance labels Nov 15, 2023
@AJPfleger AJPfleger marked this pull request as ready for review November 15, 2023 17:51
paulgessinger
paulgessinger previously approved these changes Nov 16, 2023
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@paulgessinger paulgessinger added this to the v31.0.0 milestone Nov 16, 2023
@kodiakhq kodiakhq bot removed the automerge label Nov 16, 2023
Copy link
Contributor

kodiakhq bot commented Nov 16, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

paulgessinger
paulgessinger previously approved these changes Nov 16, 2023
@andiwand
Copy link
Contributor

can you resolve the conflict @AJPfleger ?

@benjaminhuth
Copy link
Member

benjaminhuth commented Nov 20, 2023

@AJPfleger You could also add an option to the writer to avoid changes in the unrelated outputs (see https://github.com/benjaminhuth/acts/blob/478bde937ccffb6b3b4cf51be3c765ed040b3743/Examples/Io/Root/include/ActsExamples/Io/Root/RootTrackSummaryWriter.hpp#L71)

(sorry for this late comment, you can also ignore it if everything is in place already)

@github-actions github-actions bot removed Infrastructure Changes to build tools, continous integration, ... Changes Performance labels Nov 21, 2023
paulgessinger
paulgessinger previously approved these changes Nov 22, 2023
Copy link
Contributor

kodiakhq bot commented Nov 22, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@paulgessinger
Copy link
Member

This picked up a merge conflict now, which you'd have to manually resolve @AJPfleger.

@kodiakhq kodiakhq bot merged commit 34fde98 into acts-project:main Nov 22, 2023
51 checks passed
@AJPfleger AJPfleger deleted the gx2f-root-nupdate branch November 22, 2023 16:49
@acts-project-service
Copy link
Collaborator

@paulgessinger paulgessinger modified the milestones: next, v31.1.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants