Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove possible wrong function in binUtility #2666

Merged
merged 8 commits into from
Nov 24, 2023

Conversation

AJPfleger
Copy link
Contributor

@AJPfleger AJPfleger commented Nov 14, 2023

The code is imported and so old, that we don't know what the function should really do -> remove.

resolves #2622

@github-actions github-actions bot added the Component - Core Affects the Core module label Nov 14, 2023
@AJPfleger AJPfleger changed the title fix: remove possible wrong function in binUtility: inside(const Vector2& lposition) fix: remove possible wrong function in binUtility Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ecb139f) 49.50% compared to head (3a9aa33) 49.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2666   +/-   ##
=======================================
  Coverage   49.50%   49.50%           
=======================================
  Files         475      475           
  Lines       26975    26975           
  Branches    12454    12454           
=======================================
  Hits        13355    13355           
  Misses       4762     4762           
  Partials     8858     8858           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulgessinger
Copy link
Member

@asalzburger do you remember anything about this?

@AJPfleger
Copy link
Contributor Author

@asalzburger said on Friday to have no memory about it and we can remove it.

@benjaminhuth
Copy link
Member

So technically this is definitively breaking, right?

@andiwand andiwand modified the milestones: v32.0.0, next Nov 20, 2023
@kodiakhq kodiakhq bot merged commit a1c697c into acts-project:main Nov 24, 2023
51 checks passed
@AJPfleger AJPfleger deleted the yolo branch November 24, 2023 13:06
@acts-project-service
Copy link
Collaborator

@paulgessinger paulgessinger modified the milestones: next, v31.1.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: binUtility: inside(const Vector2& lposition) might be wrong
5 participants