Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Disable FPE mask printing if FPEMON is disabled by envvar #2670

Conversation

benjaminhuth
Copy link
Member

The summary of the FPE masks is quite verbose, and if the environment variable ACTS_SEQUENCER_DISABLE_FPEMON is set, one is probably not interested in this output.

@benjaminhuth benjaminhuth added this to the next milestone Nov 14, 2023
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@8c2b8c0). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2670   +/-   ##
=======================================
  Coverage        ?   49.73%           
=======================================
  Files           ?      474           
  Lines           ?    26872           
  Branches        ?    12364           
=======================================
  Hits            ?    13366           
  Misses          ?     4702           
  Partials        ?     8804           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit fbfd389 into acts-project:main Nov 16, 2023
54 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Nov 16, 2023
@paulgessinger paulgessinger modified the milestones: next, v31.0.0 Nov 16, 2023
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants