Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add script and CI job to force std::size_t over size_t #2671

Merged
merged 7 commits into from
Nov 15, 2023

Conversation

paulgessinger
Copy link
Member

No description provided.

@paulgessinger paulgessinger added this to the next milestone Nov 14, 2023
@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Component - Core Affects the Core module Component - Fatras Affects the Fatras module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Event Data Model Clustering Vertexing Seeding Track Finding Track Fitting Ambiguity Resolution and removed Component - Core Affects the Core module Component - Fatras Affects the Fatras module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Event Data Model Clustering Vertexing Seeding Track Finding Track Fitting Ambiguity Resolution labels Nov 14, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Fatras Affects the Fatras module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Event Data Model labels Nov 14, 2023
andiwand
andiwand previously approved these changes Nov 15, 2023
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@paulgessinger paulgessinger marked this pull request as ready for review November 15, 2023 09:01
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e9ff5da) 49.72% compared to head (e891dda) 49.72%.

Files Patch % Lines
...nclude/Acts/TrackFitting/GlobalChiSquareFitter.hpp 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2671   +/-   ##
=======================================
  Coverage   49.72%   49.72%           
=======================================
  Files         474      474           
  Lines       26870    26870           
  Branches    12365    12365           
=======================================
  Hits        13361    13361           
  Misses       4705     4705           
  Partials     8804     8804           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AJPfleger
AJPfleger previously approved these changes Nov 15, 2023
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through the first 100 files, seems to work.

CI/check_size_t.py Outdated Show resolved Hide resolved
AJPfleger
AJPfleger previously approved these changes Nov 15, 2023
@AJPfleger
Copy link
Contributor

I just noticed, that we also have cuda files .cu and .cuh containing size_t.

@acts-policybot acts-policybot bot dismissed AJPfleger’s stale review November 15, 2023 14:05

Invalidated by push of 3d335be

@paulgessinger
Copy link
Member Author

@AJPfleger Ok, added now.

@github-actions github-actions bot added the Component - Documentation Affects the documentation label Nov 15, 2023
@github-actions github-actions bot removed the Component - Documentation Affects the documentation label Nov 15, 2023
@asalzburger asalzburger merged commit bd74d01 into acts-project:main Nov 15, 2023
54 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Nov 15, 2023
@paulgessinger paulgessinger modified the milestones: next, v31.0.0 Nov 16, 2023
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ambiguity Resolution Clustering Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Fatras Affects the Fatras module Component - Plugins Affects one or more Plugins Event Data Model Infrastructure Changes to build tools, continous integration, ... Seeding Track Finding Track Fitting Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants