-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Shrink z range with deltaZMax in Orthogonal seeding #2673
Merged
kodiakhq
merged 7 commits into
acts-project:main
from
LuisFelipeCoelho:shrink-z-orthogonal
Dec 7, 2023
Merged
refactor: Shrink z range with deltaZMax in Orthogonal seeding #2673
kodiakhq
merged 7 commits into
acts-project:main
from
LuisFelipeCoelho:shrink-z-orthogonal
Dec 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisFelipeCoelho
changed the title
refactor: shrink z range with deltaZMax in Orthogonal seeding
refactor: Shrink z range with deltaZMax in Orthogonal seeding
Nov 15, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2673 +/- ##
=======================================
Coverage 48.69% 48.69%
=======================================
Files 479 479
Lines 27894 27894
Branches 13173 13173
=======================================
Hits 13583 13583
Misses 4765 4765
Partials 9546 9546 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 0726fcephysmon summary
|
AJPfleger
requested changes
Nov 15, 2023
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
AJPfleger
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of applying the cut directly, we shrink z range with deltaZMax.
This should not affect the physics performance.