Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Shrink z range with deltaZMax in Orthogonal seeding #2673

Merged
merged 7 commits into from
Dec 7, 2023

Conversation

LuisFelipeCoelho
Copy link
Member

@LuisFelipeCoelho LuisFelipeCoelho commented Nov 15, 2023

Instead of applying the cut directly, we shrink z range with deltaZMax.
This should not affect the physics performance.

@LuisFelipeCoelho LuisFelipeCoelho changed the title refactor: shrink z range with deltaZMax in Orthogonal seeding refactor: Shrink z range with deltaZMax in Orthogonal seeding Nov 15, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Seeding labels Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12de1e2) 48.69% compared to head (0726fce) 48.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2673   +/-   ##
=======================================
  Coverage   48.69%   48.69%           
=======================================
  Files         479      479           
  Lines       27894    27894           
  Branches    13173    13173           
=======================================
  Hits        13583    13583           
  Misses       4765     4765           
  Partials     9546     9546           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuisFelipeCoelho LuisFelipeCoelho marked this pull request as ready for review November 15, 2023 12:36
LuisFelipeCoelho and others added 3 commits November 15, 2023 15:18
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
@paulgessinger paulgessinger added this to the next milestone Dec 6, 2023
@kodiakhq kodiakhq bot merged commit c65d419 into acts-project:main Dec 7, 2023
52 checks passed
@github-actions github-actions bot removed the automerge label Dec 7, 2023
@acts-project-service
Copy link
Collaborator

✅ Athena integration test results [c65d419]

✅ All tests successful

status job
🟢 run_unit_tests
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateAmbiguityResolution.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateResolvedTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsGSFRefitting.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco

@paulgessinger paulgessinger modified the milestones: next, v31.2.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Seeding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants