Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve Bethe Heitler approximation constructors and logging #2679

Merged

Conversation

benjaminhuth
Copy link
Member

This makes the constructors more flexible (but still a bit awkward to not break the interface without need), and improves the comments about invalid bethe heitler descriptions...

@benjaminhuth benjaminhuth added this to the next milestone Nov 16, 2023
andiwand
andiwand previously approved these changes Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (fd1e0b4) 49.63% compared to head (8935961) 49.74%.

❗ Current head 8935961 differs from pull request most recent head 2f828e4. Consider uploading reports for the commit 2f828e4 to get more accurate results

Files Patch % Lines
...e/include/Acts/TrackFitting/BetheHeitlerApprox.hpp 57.14% 4 Missing and 2 partials ⚠️
Core/include/Acts/TrackFitting/detail/GsfActor.hpp 16.66% 2 Missing and 3 partials ⚠️
...re/include/Acts/TrackFitting/GaussianSumFitter.hpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2679      +/-   ##
==========================================
+ Coverage   49.63%   49.74%   +0.10%     
==========================================
  Files         474      474              
  Lines       26941    26876      -65     
  Branches    12415    12364      -51     
==========================================
- Hits        13372    13369       -3     
+ Misses       4746     4703      -43     
+ Partials     8823     8804      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 01ebd59 into acts-project:main Nov 17, 2023
48 checks passed
@paulgessinger paulgessinger modified the milestones: next, v31.1.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants