-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Improve Bethe Heitler approximation constructors and logging #2679
Merged
kodiakhq
merged 8 commits into
acts-project:main
from
benjaminhuth:refactor/improve-bha-constructors
Nov 17, 2023
Merged
refactor: Improve Bethe Heitler approximation constructors and logging #2679
kodiakhq
merged 8 commits into
acts-project:main
from
benjaminhuth:refactor/improve-bha-constructors
Nov 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
previously approved these changes
Nov 16, 2023
github-actions
bot
added
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Track Fitting
labels
Nov 16, 2023
andiwand
approved these changes
Nov 16, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2679 +/- ##
==========================================
+ Coverage 49.63% 49.74% +0.10%
==========================================
Files 474 474
Lines 26941 26876 -65
Branches 12415 12364 -51
==========================================
- Hits 13372 13369 -3
+ Misses 4746 4703 -43
+ Partials 8823 8804 -19 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Track Fitting
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the constructors more flexible (but still a bit awkward to not break the interface without need), and improves the comments about invalid bethe heitler descriptions...