-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Remove implicit default layer from CuboidVolumeBuilder
#2681
refactor!: Remove implicit default layer from CuboidVolumeBuilder
#2681
Conversation
CuboidVolumeBuilder
CuboidVolumeBuilder
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2681 +/- ##
=======================================
Coverage 48.84% 48.85%
=======================================
Files 484 484
Lines 28138 28120 -18
Branches 13277 13264 -13
=======================================
- Hits 13743 13737 -6
- Misses 4797 4807 +10
+ Partials 9598 9576 -22 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 6a87ae5physmon summary
|
CuboidVolumeBuilder
CuboidVolumeBuilder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed also by Paul - uncontroversial.
…cts-project#2681) This is a pitfall and does not allow to build volumes without layers
This is a pitfall and does not allow to build volumes without layers