Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Remove implicit default layer from CuboidVolumeBuilder #2681

Merged

Conversation

andiwand
Copy link
Contributor

This is a pitfall and does not allow to build volumes without layers

@andiwand andiwand added this to the next milestone Nov 16, 2023
@github-actions github-actions bot added the Component - Core Affects the Core module label Nov 16, 2023
@andiwand andiwand changed the title refactor: Rremove implicit default layer from CuboidVolumeBuilder refactor: Remove implicit default layer from CuboidVolumeBuilder Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (eeec852) 48.84% compared to head (6a87ae5) 48.85%.

Files Patch % Lines
Core/src/Geometry/LayerArrayCreator.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2681   +/-   ##
=======================================
  Coverage   48.84%   48.85%           
=======================================
  Files         484      484           
  Lines       28138    28120   -18     
  Branches    13277    13264   -13     
=======================================
- Hits        13743    13737    -6     
- Misses       4797     4807   +10     
+ Partials     9598     9576   -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andiwand andiwand changed the title refactor: Remove implicit default layer from CuboidVolumeBuilder refactor!: Remove implicit default layer from CuboidVolumeBuilder Nov 20, 2023
@andiwand andiwand requested a review from pbutti November 24, 2023 13:05
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in.

@kodiakhq kodiakhq bot merged commit 2dbf768 into acts-project:main Dec 16, 2023
52 checks passed
@andiwand andiwand deleted the remove-implicit-default-layer-cuboidgeo branch December 16, 2023 13:44
@acts-project-service
Copy link
Collaborator

✅ Athena integration test results [2dbf768]

✅ All tests successful

status job report
🟢 run_unit_tests
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateAmbiguityResolution.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateResolvedTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsGSFRefitting.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco

Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed also by Paul - uncontroversial.

@paulgessinger paulgessinger modified the milestones: next, v32.0.0 Jan 19, 2024
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
…cts-project#2681)

This is a pitfall and does not allow to build volumes without layers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants