-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fitters: connect void default accessors #2688
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Affects the Core module
Event Data Model
Track Fitting
labels
Nov 16, 2023
CarloVarni
changed the title
fix: Kalman Fitter: connect void default surface accessor to KF
fix: Fitters: connect void default accessors
Nov 16, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2688 +/- ##
=======================================
Coverage 49.70% 49.70%
=======================================
Files 474 474
Lines 26884 26892 +8
Branches 12374 12376 +2
=======================================
+ Hits 13364 13368 +4
- Misses 4706 4710 +4
Partials 8814 8814 ☔ View full report in Codecov by Sentry. |
andiwand
approved these changes
Nov 17, 2023
acts-project-service
added
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Nov 17, 2023
paulgessinger
removed
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default void accessors that throws an error if the user forgets to set them. Right now this may cause crashes if the user forgets as @toyamaza has noticed in Athena