Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fitters: connect void default accessors #2688

Merged
merged 6 commits into from
Nov 17, 2023

Conversation

CarloVarni
Copy link
Collaborator

@CarloVarni CarloVarni commented Nov 16, 2023

Default void accessors that throws an error if the user forgets to set them. Right now this may cause crashes if the user forgets as @toyamaza has noticed in Athena

@CarloVarni CarloVarni added this to the next milestone Nov 16, 2023
@CarloVarni CarloVarni changed the title fix: Kalman Fitter: connect void default surface accessor to KF fix: Fitters: connect void default accessors Nov 16, 2023
@CarloVarni CarloVarni added the Bug Something isn't working label Nov 16, 2023
@CarloVarni CarloVarni modified the milestones: next, v31.0.0 Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (46dd473) 49.70% compared to head (b53ad1d) 49.70%.

Files Patch % Lines
.../Acts/TrackFitting/detail/VoidFitterComponents.hpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2688   +/-   ##
=======================================
  Coverage   49.70%   49.70%           
=======================================
  Files         474      474           
  Lines       26884    26892    +8     
  Branches    12374    12376    +2     
=======================================
+ Hits        13364    13368    +4     
- Misses       4706     4710    +4     
  Partials     8814     8814           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 394192a into acts-project:main Nov 17, 2023
51 checks passed
@CarloVarni CarloVarni deleted the KfDefDelegate branch November 17, 2023 10:18
@acts-project-service
Copy link
Collaborator

acts-project-service commented Nov 17, 2023

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Nov 17, 2023
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Component - Core Affects the Core module Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants