Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more unit tests for Json writing #2693

Conversation

asalzburger
Copy link
Contributor

This PR adds more testing to the Json converters:

  • the most common grid types are now tested for writing reading
  • the detector volume finder is also written as such

@asalzburger asalzburger added this to the next milestone Nov 17, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Plugins Affects one or more Plugins labels Nov 17, 2023
@asalzburger asalzburger changed the title feat: a more unit tests for Json writing feat: add more unit tests for Json writing Nov 17, 2023
asalzburger and others added 3 commits November 17, 2023 16:01
…Tests.cpp

Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (fd1e0b4) 49.63% compared to head (669a5f6) 49.64%.
Report is 1 commits behind head on main.

Files Patch % Lines
...e/include/Acts/TrackFitting/BetheHeitlerApprox.hpp 57.14% 4 Missing and 2 partials ⚠️
Core/include/Acts/TrackFitting/detail/GsfActor.hpp 16.66% 2 Missing and 3 partials ⚠️
...re/include/Acts/TrackFitting/GaussianSumFitter.hpp 66.66% 1 Missing ⚠️
...re/src/Detector/IndexedRootVolumeFinderBuilder.cpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2693   +/-   ##
=======================================
  Coverage   49.63%   49.64%           
=======================================
  Files         474      474           
  Lines       26941    26946    +5     
  Branches    12415    12415           
=======================================
+ Hits        13372    13376    +4     
- Misses       4746     4747    +1     
  Partials     8823     8823           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asalzburger asalzburger merged commit 27fc8ec into acts-project:main Nov 18, 2023
50 checks passed
@asalzburger asalzburger deleted the feat-add-detector-volume-finder-unittest branch November 18, 2023 11:58
@acts-project-service
Copy link
Collaborator

acts-project-service commented Nov 18, 2023

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Nov 18, 2023
@paulgessinger paulgessinger modified the milestones: next, v31.1.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Plugins Affects one or more Plugins Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants