-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more unit tests for Json writing #2693
Merged
asalzburger
merged 10 commits into
acts-project:main
from
asalzburger:feat-add-detector-volume-finder-unittest
Nov 18, 2023
Merged
feat: add more unit tests for Json writing #2693
asalzburger
merged 10 commits into
acts-project:main
from
asalzburger:feat-add-detector-volume-finder-unittest
Nov 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Affects the Core module
Component - Plugins
Affects one or more Plugins
labels
Nov 17, 2023
AJPfleger
requested changes
Nov 17, 2023
Tests/UnitTests/Plugins/Json/DetectorVolumeFinderJsonConverterTests.cpp
Outdated
Show resolved
Hide resolved
asalzburger
changed the title
feat: a more unit tests for Json writing
feat: add more unit tests for Json writing
Nov 17, 2023
…Tests.cpp Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2693 +/- ##
=======================================
Coverage 49.63% 49.64%
=======================================
Files 474 474
Lines 26941 26946 +5
Branches 12415 12415
=======================================
+ Hits 13372 13376 +4
- Misses 4746 4747 +1
Partials 8823 8823 ☔ View full report in Codecov by Sentry. |
AJPfleger
approved these changes
Nov 18, 2023
acts-project-service
added
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Core
Affects the Core module
Component - Plugins
Affects one or more Plugins
Fails Athena tests
This PR causes a failure in the Athena tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more testing to the Json converters: