-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Collect and write material statistics in GSF #2695
feat: Collect and write material statistics in GSF #2695
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2695 +/- ##
=======================================
Coverage 49.53% 49.54%
=======================================
Files 474 474
Lines 26944 26969 +25
Branches 12435 12446 +11
=======================================
+ Hits 13348 13361 +13
- Misses 4751 4755 +4
- Partials 8845 8853 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good idea. I don't fully understand the design. Outputs change because of added columns.
Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
@paulgessinger Now updated so that it does not change the outputs of other workflows. If this runs through green, can you approve? |
This refactors the collection of material statistics in the GSF, so it only accumulates values until the last measurement in the forward pass (not collecting material in the solenoid etc...)
Also writes the sum and the maximum material of the forward pass to the tracksummary.