Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Collect and write material statistics in GSF #2695

Merged
merged 10 commits into from
Nov 22, 2023

Conversation

benjaminhuth
Copy link
Member

This refactors the collection of material statistics in the GSF, so it only accumulates values until the last measurement in the forward pass (not collecting material in the solenoid etc...)

Also writes the sum and the maximum material of the forward pass to the tracksummary.

@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Track Fitting labels Nov 17, 2023
@benjaminhuth benjaminhuth added this to the next milestone Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (60ff980) 49.53% compared to head (ba1b62a) 49.54%.

Files Patch % Lines
...re/include/Acts/TrackFitting/GaussianSumFitter.hpp 53.33% 4 Missing and 3 partials ⚠️
Core/include/Acts/TrackFitting/detail/GsfActor.hpp 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2695   +/-   ##
=======================================
  Coverage   49.53%   49.54%           
=======================================
  Files         474      474           
  Lines       26944    26969   +25     
  Branches    12435    12446   +11     
=======================================
+ Hits        13348    13361   +13     
- Misses       4751     4755    +4     
- Partials     8845     8853    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea. I don't fully understand the design. Outputs change because of added columns.

Core/include/Acts/TrackFitting/detail/GsfActor.hpp Outdated Show resolved Hide resolved
Core/include/Acts/TrackFitting/detail/GsfActor.hpp Outdated Show resolved Hide resolved
Core/include/Acts/TrackFitting/detail/GsfActor.hpp Outdated Show resolved Hide resolved
Core/include/Acts/TrackFitting/detail/GsfActor.hpp Outdated Show resolved Hide resolved
@benjaminhuth
Copy link
Member Author

@paulgessinger Now updated so that it does not change the outputs of other workflows. If this runs through green, can you approve?

@kodiakhq kodiakhq bot merged commit 3fd1e0f into acts-project:main Nov 22, 2023
51 checks passed
@benjaminhuth benjaminhuth deleted the feat/gsf-collect-mat-stats branch November 22, 2023 11:09
@acts-project-service
Copy link
Collaborator

@paulgessinger paulgessinger modified the milestones: next, v31.1.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants