Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rewrite KF with less code recicle #2705

Merged

Conversation

CarloVarni
Copy link
Collaborator

Isolate common pieces of code for the fit methods of the KF. The difference between the two fit methods is simply the list of surface sequence, and that ends in the KalmanFitterOptions. The rest of the code is the same

@CarloVarni CarloVarni added this to the next milestone Nov 21, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Track Fitting labels Nov 21, 2023
Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side looks ok, let's see what the tests say.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (37a2f9e) 49.54% compared to head (f368627) 49.55%.

Files Patch % Lines
Core/include/Acts/TrackFitting/KalmanFitter.hpp 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2705   +/-   ##
=======================================
  Coverage   49.54%   49.55%           
=======================================
  Files         474      474           
  Lines       26929    26932    +3     
  Branches    12425    12426    +1     
=======================================
+ Hits        13343    13345    +2     
  Misses       4749     4749           
- Partials     8837     8838    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 082e64d into acts-project:main Nov 21, 2023
49 checks passed
@acts-project-service
Copy link
Collaborator

@paulgessinger paulgessinger modified the milestones: next, v31.1.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants