-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Rewrite KF with less code recicle #2705
refactor: Rewrite KF with less code recicle #2705
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side looks ok, let's see what the tests say.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2705 +/- ##
=======================================
Coverage 49.54% 49.55%
=======================================
Files 474 474
Lines 26929 26932 +3
Branches 12425 12426 +1
=======================================
+ Hits 13343 13345 +2
Misses 4749 4749
- Partials 8837 8838 +1 ☔ View full report in Codecov by Sentry. |
Isolate common pieces of code for the
fit
methods of the KF. The difference between the twofit
methods is simply the list of surface sequence, and that ends in the KalmanFitterOptions. The rest of the code is the same