Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change WARNING to DEBUG for CKF No tracks found #2719

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

timadye
Copy link
Contributor

@timadye timadye commented Nov 23, 2023

If using a stopper, one can correctly have seeds with no tracks found. This should not be a WARNING.

@github-actions github-actions bot added Component - Core Affects the Core module Track Finding labels Nov 23, 2023
@CarloVarni CarloVarni added this to the next milestone Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (b77e16e) 49.52% compared to head (087e20f) 49.50%.
Report is 1 commits behind head on main.

Files Patch % Lines
Core/include/Acts/Seeding/SeedFinder.ipp 0.00% 5 Missing ⚠️
...clude/Acts/Seeding/SeedConfirmationRangeConfig.hpp 0.00% 2 Missing ⚠️
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2719      +/-   ##
==========================================
- Coverage   49.52%   49.50%   -0.02%     
==========================================
  Files         474      475       +1     
  Lines       26968    26975       +7     
  Branches    12452    12454       +2     
==========================================
  Hits        13355    13355              
- Misses       4755     4762       +7     
  Partials     8858     8858              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 33c94a6 into acts-project:main Nov 24, 2023
51 checks passed
@acts-project-service
Copy link
Collaborator

@paulgessinger paulgessinger modified the milestones: next, v31.1.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants