-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Improve edge classifier performance #2734
Merged
kodiakhq
merged 3 commits into
acts-project:main
from
benjaminhuth:refactor/exatrkx-clf-chunks
Nov 28, 2023
Merged
perf: Improve edge classifier performance #2734
kodiakhq
merged 3 commits into
acts-project:main
from
benjaminhuth:refactor/exatrkx-clf-chunks
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2734 +/- ##
=======================================
Coverage 49.50% 49.50%
=======================================
Files 475 475
Lines 26973 26973
Branches 12453 12453
=======================================
Hits 13353 13353
Misses 4762 4762
Partials 8858 8858 ☔ View full report in Codecov by Sentry. |
andiwand
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the case of 0 chunks. The value of the chunk option is actually questionable, but this should be addressed at a different point.