fix: GX2F: Finish material-less fit by resetting the track container

[AJPfleger]

It is probably not the most optimal solution but it makes the GX2F (Global Chi Square Fitter) work. Instead of revisiting and updating track states during each iteration, we now flush the track container after each iteration and add them from scratch.

Regarding the performance: The track container works similar to a vector, so by clearing it the space for n track states remains reserved, which makes this approach less bad than one might suspect.

This finally gives us also nice phi-, theta-, and q/p-pulls with the Generic detector. We can also see that we most of the time only need 3-4 updates for convergence.

Generic Detector

MomentumConfig(100.0 * u.GeV, 100.0 * u.GeV, transverse=True),
EtaConfig(-3.0, 3.0),
PhiConfig(0.00 * u.degree, 360.00 * u.degree),
nUpdateMax=17,
zeroField=False,
relChi2changeCutOff=1e-11,

[codecov]

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (c65d419) 48.69% compared to head (14ea9ef) 49.56%.

❗ Current head 14ea9ef differs from pull request most recent head dc71e2c. Consider uploading reports for the commit dc71e2c to get more accurate results

Files	Patch %	Lines
...nclude/Acts/TrackFitting/GlobalChiSquareFitter.hpp	28.57%	1 Missing and 9 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2739      +/-   ##
==========================================
+ Coverage   48.69%   49.56%   +0.86%     
==========================================
  Files         479      474       -5     
  Lines       27894    27059     -835     
  Branches    13173    12502     -671     
==========================================
- Hits        13583    13411     -172     
+ Misses       4765     4748      -17     
+ Partials     9546     8900     -646     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📊: Physics performance monitoring for dc71e2c

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles fatras
• ✅ Particles geant4

[asalzburger]

I would be in favour to get this in, in order to have a first application test outside our ecosystem.

[paulgessinger]

I think the logging output probably needs an overhaul in any case: multi-line outputs in the logger often look weird anyway. But this is not a blocker for the actual change, so let's go.

[acts-project-service]

✅ Athena integration test results

✅ All tests successful

status	job	report
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateAmbiguityResolution.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateResolvedTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsGSFRefitting.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco