Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove redundant default-constructor factory for Nav delegate #2741

Merged
merged 5 commits into from
Dec 12, 2023
Merged

refactor: Remove redundant default-constructor factory for Nav delegate #2741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a3eb60d
chore: Remove redundant default-constructor factory for Nav delegate
paulgessinger Nov 29, 2023
42be536
Merge branch 'main' into rm-unconnectedUpdator
paulgessinger Nov 29, 2023
fca1ef0
Merge remote-tracking branch 'origin/main' into rm-unconnectedUpdator
paulgessinger Nov 29, 2023
a6c7176
Merge branch 'main' into rm-unconnectedUpdator
kodiakhq[bot] Dec 12, 2023
69d9e7d
Merge branch 'main' into rm-unconnectedUpdator
kodiakhq[bot] Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Core/include/Acts/Detector/Portal.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ class Portal {
std::shared_ptr<RegularSurface> m_surface;

/// The portal targets along/opposite the normal vector
DetectorVolumeUpdaters m_volumeUpdaters = {unconnectedUpdater(),
unconnectedUpdater()};
DetectorVolumeUpdaters m_volumeUpdaters = {DetectorVolumeUpdater{},
DetectorVolumeUpdater{}};

/// The portal attaches to the following volumes
AttachedDetectorVolumes m_attachedVolumes;
Expand Down
7 changes: 0 additions & 7 deletions Core/include/Acts/Navigation/NavigationDelegates.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,5 @@ using DetectorVolumeUpdater =
OwningDelegate<void(const GeometryContext& gctx, NavigationState& nState),
INavigationDelegate>;

/// @brief A dummy constructed updator
inline static DetectorVolumeUpdater unconnectedUpdater() {
DetectorVolumeUpdater unconnected;
unconnected.disconnect();
return unconnected;
}

} // namespace Experimental
} // namespace Acts
Loading