fix: generic_plotter.py: skip empty branches

[AJPfleger]

In case of an empty branch the plotter crashed when calculating the limits. Now we skip those branches and generate no plots for them.

Traceback (most recent call last):

  File "<source>/Examples/Scripts/generic_plotter.py", line 209, in <module>
    typer.run(main)

  File "<source>/Examples/Scripts/generic_plotter.py", line 139, in main
    found.min -= 1

TypeError: unsupported operand type(s) for -=: 'NoneType' and 'int'

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1bf0daf) 49.51% compared to head (89a34da) 49.51%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2742   +/-   ##
=======================================
  Coverage   49.51%   49.51%           
=======================================
  Files         475      475           
  Lines       26965    26965           
  Branches    12447    12447           
=======================================
  Hits        13352    13352           
  Misses       4764     4764           
  Partials     8849     8849           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📊: Physics performance monitoring for 89a34da

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles fatras
• ✅ Particles geant4

[felix-russo]

Is it expected behavior to have empty branches?

[AJPfleger]

Here we can generate a root-file with some empty branches. (outlierChi2, outlierVolume, outlierLayer) since the GX2F doesn't do outliers (yet).

acts/Examples/Scripts/Python/truth_tracking_gx2f.py

Line 116 in 1bf0daf

acts.examples.RootTrackSummaryWriter(

Maybe it is unexpected from the Writer- or GX2F-side, but I think the plotter shouldn't refuse to plot the other (valid) branches.

[acts-project-service]

✅ Athena integration test results [cf14470]

✅ All tests successful

status	job
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateAmbiguityResolution.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateResolvedTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsGSFRefitting.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data