Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detray json writing fixes #2743

Merged
merged 7 commits into from
Nov 29, 2023

Conversation

asalzburger
Copy link
Contributor

This PR contains three fixes for detray json writing:

  • local binning is offset to 0 (instead of ACTS 1)
  • correction to global frame for volume links
  • axis swapping & patchting for phi,z grids

@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf14470) 49.51% compared to head (8310440) 49.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2743   +/-   ##
=======================================
  Coverage   49.51%   49.51%           
=======================================
  Files         475      475           
  Lines       26965    26965           
  Branches    12447    12447           
=======================================
  Hits        13352    13352           
  Misses       4764     4764           
  Partials     8849     8849           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

niermann999
niermann999 previously approved these changes Nov 29, 2023
@asalzburger asalzburger added this to the next milestone Nov 29, 2023
Copy link
Contributor

kodiakhq bot commented Nov 29, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@kodiakhq kodiakhq bot removed the automerge label Nov 29, 2023
@asalzburger
Copy link
Contributor Author

Sorry, Merge conflict - fixing It invalidated the approval.

@kodiakhq kodiakhq bot merged commit cf84e21 into acts-project:main Nov 29, 2023
51 checks passed
@acts-project-service
Copy link
Collaborator

@paulgessinger paulgessinger modified the milestones: next, v31.2.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Plugins Affects one or more Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants