-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: detray json writing fixes #2743
Merged
kodiakhq
merged 7 commits into
acts-project:main
from
asalzburger:fix-detray-json-writing
Nov 29, 2023
Merged
fix: detray json writing fixes #2743
kodiakhq
merged 7 commits into
acts-project:main
from
asalzburger:fix-detray-json-writing
Nov 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2743 +/- ##
=======================================
Coverage 49.51% 49.51%
=======================================
Files 475 475
Lines 26965 26965
Branches 12447 12447
=======================================
Hits 13352 13352
Misses 4764 4764
Partials 8849 8849 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 8310440physmon summary
|
niermann999
previously approved these changes
Nov 29, 2023
This PR currently has a merge conflict. Please resolve this and then re-add the |
acts-policybot
bot
dismissed
niermann999’s stale review
November 29, 2023 19:11
Invalidated by push of 8310440
Sorry, Merge conflict - fixing It invalidated the approval. |
niermann999
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains three fixes for detray json writing: