Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix CKF pathlimit abort #2744

Merged
merged 6 commits into from
Dec 5, 2023

Conversation

andiwand
Copy link
Contributor

The CKF has special path limit treatment during propagation which is overruled by propagation internal path limit aborter in some cases. Here I try to improve this by putting a stub into the propagation

@andiwand andiwand added this to the next milestone Nov 29, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Track Finding labels Nov 29, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (9bfcfc1) 49.48% compared to head (1ec4473) 49.48%.

Files Patch % Lines
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp 41.66% 0 Missing and 7 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2744   +/-   ##
=======================================
  Coverage   49.48%   49.48%           
=======================================
  Files         474      474           
  Lines       27069    27075    +6     
  Branches    12513    12516    +3     
=======================================
+ Hits        13395    13399    +4     
+ Misses       4765     4762    -3     
- Partials     8909     8914    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clear - makes sense.

@paulgessinger paulgessinger added ready Ready to merge, but not being merged yet and removed automerge labels Dec 5, 2023
@andiwand andiwand added automerge and removed ready Ready to merge, but not being merged yet labels Dec 5, 2023
@kodiakhq kodiakhq bot merged commit 04544d9 into acts-project:main Dec 5, 2023
52 checks passed
@github-actions github-actions bot removed the automerge label Dec 5, 2023
@andiwand andiwand deleted the fix-ckf-pathlimit-abort branch December 5, 2023 15:58
@acts-project-service
Copy link
Collaborator

✅ Athena integration test results [04544d9]

✅ All tests successful

status job
🟢 run_unit_tests
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateAmbiguityResolution.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateResolvedTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsGSFRefitting.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco

@paulgessinger paulgessinger modified the milestones: next, v31.2.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants