-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix CKF pathlimit abort #2744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊: Physics performance monitoring for 1ec4473physmon summary
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2744 +/- ##
=======================================
Coverage 49.48% 49.48%
=======================================
Files 474 474
Lines 27069 27075 +6
Branches 12513 12516 +3
=======================================
+ Hits 13395 13399 +4
+ Misses 4765 4762 -3
- Partials 8909 8914 +5 ☔ View full report in Codecov by Sentry. |
asalzburger
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clear - makes sense.
paulgessinger
added
ready
Ready to merge, but not being merged yet
and removed
automerge
labels
Dec 5, 2023
andiwand
added
automerge
and removed
ready
Ready to merge, but not being merged yet
labels
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CKF has special path limit treatment during propagation which is overruled by propagation internal path limit aborter in some cases. Here I try to improve this by putting a stub into the propagation