feat: template KalmanVertexUpdater to optionally fit time #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2751 +/- ##
==========================================
- Coverage 49.52% 49.51% -0.01%
==========================================
Files 474 474
Lines 27023 27064 +41
Branches 12480 12507 +27
==========================================
+ Hits 13383 13401 +18
+ Misses 4764 4761 -3
- Partials 8876 8902 +26 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 5c7b64ephysmon summary
|
felix-russo
changed the title
AJPfleger
requested changes
Nov 30, 2023
Tests/UnitTests/Core/Vertexing/AdaptiveMultiVertexFitterTests.cpp
Outdated
Show resolved
Hide resolved
Tests/UnitTests/Core/Vertexing/AdaptiveMultiVertexFitterTests.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
AJPfleger
approved these changes
Dec 1, 2023
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
Dec 6, 2023
…ct#2751) Adds a template parameter `nDimVertex` to `KalmanVertexUpdater` and `KalmanVertexTrackUpdater`. The new parameter controls whether we perform a usual spatial fit (`nDimVertex = 3`) or if we also fit time (`nDimVertex = 4`). Adds a unit test for Kalman time fitting. Should not break athena! In the long term, we should think about always fitting time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a template parameter
nDimVertextoKalmanVertexUpdaterandKalmanVertexTrackUpdater. The new parameter controls whether we perform a usual spatial fit (nDimVertex = 3) or if we also fit time (nDimVertex = 4).Adds a unit test for Kalman time fitting.
Should not break athena!
In the long term, we should think about always fitting time.