-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add helper and fusing infrastructure for cuboidal detectors #2754
feat: add helper and fusing infrastructure for cuboidal detectors #2754
Conversation
📊: Physics performance monitoring for 4be3eb8physmon summary
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2754 +/- ##
=========================================
+ Coverage 0 48.84% +48.84%
=========================================
Files 0 491 +491
Lines 0 28529 +28529
Branches 0 13477 +13477
=========================================
+ Hits 0 13936 +13936
- Misses 0 4868 +4868
- Partials 0 9725 +9725 ☔ View full report in Codecov by Sentry. |
Container - container fusing is missing in the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you plan to include the tests for the container fusing in this PR?
Core/include/Acts/Detector/detail/DetectorVolumeConsistency.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Yes, I have included this test now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few tiny things
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Done. |
…ts-project#2754) This PR adds a new `detail/CuboidalDetectorHelper.h/cpp` for creating cuboid shape detectors. Since it reuses some code from the cylindrical infrastructure, this is encapsulated into sub helpers to not be duplicated. ![CuboidalDetector00](https://github.com/acts-project/acts/assets/26623879/19fc7cb9-7189-4535-ada9-aa2fef33f7d4) Blocked by: - acts-project#2753 (merged) This relaxes the Portal fusing to allow for two portals with same direction filled to be fused (necessary for box-2-box)
This PR adds a new
detail/CuboidalDetectorHelper.h/cpp
for creating cuboid shape detectors.
Since it reuses some code from the cylindrical infrastructure, this is encapsulated into sub helpers to not be duplicated.
Blocked by:
This relaxes the Portal fusing to allow for two portals with same direction filled to be fused (necessary for box-2-box)