refactor: Refactor navigation #2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
📊: Physics performance monitoring for 865e95aphysmon summary
|
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 16, 2023
I do not think that this interface has any benefit over `makeState` + `initialize` and should therefore be removed pulled out of #2768
Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
✅ Athena integration test results [601c041]✅ All tests successful
|
paulgessinger
previously approved these changes
Dec 18, 2023
|
Seems like there are compile errors |
paulgessinger
approved these changes
Dec 19, 2023
acts-project-service
added
the
Breaks Athena build
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
I do not think that this interface has any benefit over `makeState` + `initialize` and should therefore be removed pulled out of acts-project#2768
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
After acts-project#2625 turned out to be harder than initially thought I tried to factor out some changes to get them into main already. Summary of the changes I made - `pLimit` = path limit -> far limit = `farLimit` - `oLimit` = overstep limit -> near limit = `nearLimit` - replaced `DetectorNavigator` iterators with indices
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 31, 2024
Backporting more changes from acts-project#2625 to main. This is a followup to acts-project#2768 Summary - remove overstepping from steppers - use surface tolerance for geometry lookups - add self consistency navigation test
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
Backporting more changes from acts-project#2625 to main. This is a followup to acts-project#2768 Summary - remove overstepping from steppers - use surface tolerance for geometry lookups - add self consistency navigation test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #2625 turned out to be harder than initially thought I tried to factor out some changes to get them into main already.
Summary of the changes I made
pLimit= path limit -> far limit =farLimitoLimit= overstep limit -> near limit =nearLimitDetectorNavigatoriterators with indices