refactor: consider only tracks with non-zero weight in VertexPerfomanceWriter #2775
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2775 +/- ##
=======================================
Coverage 48.85% 48.85%
=======================================
Files 486 486
Lines 28178 28175 -3
Branches 13292 13290 -2
=======================================
Hits 13766 13766
+ Misses 4796 4794 -2
+ Partials 9616 9615 -1 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 14c3f27physmon summary
|
|
Are the physmon failures expected? |
Examples/Io/Performance/ActsExamples/Io/Performance/VertexPerformanceWriter.hpp
Show resolved
Hide resolved
Yes! Before, every track in |
…-nTracks-with-nonzero-weight
github-actions
bot
added
Infrastructure
|
I updated the references, but they might have picked up conflicts. |
|
CI is green now - can we get this in @paulgessinger? |
|
@andiwand cpuld you approve this? |
…ceWriter (acts-project#2775) Previously, every track in `TrackAtVertex` contributed to the number of tracks on the reconstructed vertex. This does not make a lot of sense, since some tracks have low weights (which means that they actually do not contribute). This PR excludes low-weight tracks from the histograms to give a better indication of the vertexing performance. Co-authored-by: Paul Gessinger <1058585+paulgessinger@users.noreply.github.com>
Previously, every track in
TrackAtVertexcontributed to the number of tracks on the reconstructed vertex. This does not make a lot of sense, since some tracks have low weights (which means that they actually do not contribute). This PR excludes low-weight tracks from the histograms to give a better indication of the vertexing performance.