Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove autodiff #2793

Merged
merged 12 commits into from
Feb 6, 2024
Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Dec 11, 2023

related issues (closes #2792)

autodiff became more of a burden at some point. Since we do not consistently template all the quantities we might want to derive later this became more of an exception. I propose to remove it for now until we have a broader solution or purpose for it

@andiwand andiwand added this to the next milestone Dec 11, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Infrastructure Changes to build tools, continous integration, ... Component - Plugins Affects one or more Plugins Component - Documentation Affects the documentation Event Data Model labels Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 116 lines in your changes are missing coverage. Please review.

Comparison is base (3a9c0bf) 48.99% compared to head (1105f56) 48.99%.

Files Patch % Lines
...lude/Acts/Propagator/DenseEnvironmentExtension.hpp 54.66% 6 Missing and 62 partials ⚠️
Core/include/Acts/Propagator/DefaultExtension.hpp 35.61% 0 Missing and 47 partials ⚠️
Core/include/Acts/EventData/Charge.hpp 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2793      +/-   ##
==========================================
- Coverage   48.99%   48.99%   -0.01%     
==========================================
  Files         496      495       -1     
  Lines       28938    28937       -1     
  Branches    13704    13704              
==========================================
- Hits        14179    14178       -1     
  Misses       4881     4881              
  Partials     9878     9878              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

asalzburger
asalzburger previously approved these changes Dec 15, 2023
Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean removal, as discussed, we should do that.

@asalzburger
Copy link
Contributor

@andiwand - can you just resolve the conflict, please?

@paulgessinger
Copy link
Member

I would like to hold this until @benjaminhuth has had a chance to look at this.

@benjaminhuth
Copy link
Member

Hmm so I'm fine with removing the plugin. However, I used the template infrastructure as well for my experimental SIMD stepper implementation for the GSF which I did not try to merge yet...

Not sure if that's an argument to keep some of the template infrastructure (mainly that of detail::GenericDefaultExtension), and I try to merge it as Acts::Experimental?

However since this is still very experimental you could also remove all of this and I would add it again in case that becomes relevant in the future...

@andiwand
Copy link
Contributor Author

I wound suggest to add the templating back in if necessary. Happy to help when this comes up

@github-actions github-actions bot added Stale and removed Stale labels Jan 17, 2024
@AJPfleger AJPfleger requested a review from asalzburger January 30, 2024 16:39
@kodiakhq kodiakhq bot merged commit c2e1e6e into acts-project:main Feb 6, 2024
54 checks passed
@github-actions github-actions bot removed the automerge label Feb 6, 2024
@andiwand andiwand deleted the remove-autodiff branch February 6, 2024 14:13
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
related issues (closes acts-project#2792)
- acts-project#2792

`autodiff` became more of a burden at some point. Since we do not consistently template all the quantities we might want to derive later this became more of an exception. I propose to remove it for now until we have a broader solution or purpose for it
@paulgessinger paulgessinger modified the milestones: next, v33.0.0 Mar 6, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
related issues (closes acts-project#2792)
- acts-project#2792

`autodiff` became more of a burden at some point. Since we do not consistently template all the quantities we might want to derive later this became more of an exception. I propose to remove it for now until we have a broader solution or purpose for it
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
related issues (closes acts-project#2792)
- acts-project#2792

`autodiff` became more of a burden at some point. Since we do not consistently template all the quantities we might want to derive later this became more of an exception. I propose to remove it for now until we have a broader solution or purpose for it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Documentation Affects the documentation Component - Plugins Affects one or more Plugins Event Data Model Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove autodiff documentation
5 participants