-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove autodiff
#2793
Conversation
📊: Physics performance monitoring for 1105f56physmon summary
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2793 +/- ##
==========================================
- Coverage 48.99% 48.99% -0.01%
==========================================
Files 496 495 -1
Lines 28938 28937 -1
Branches 13704 13704
==========================================
- Hits 14179 14178 -1
Misses 4881 4881
Partials 9878 9878 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean removal, as discussed, we should do that.
@andiwand - can you just resolve the conflict, please? |
I would like to hold this until @benjaminhuth has had a chance to look at this. |
Hmm so I'm fine with removing the plugin. However, I used the template infrastructure as well for my experimental SIMD stepper implementation for the GSF which I did not try to merge yet... Not sure if that's an argument to keep some of the template infrastructure (mainly that of However since this is still very experimental you could also remove all of this and I would add it again in case that becomes relevant in the future... |
I wound suggest to add the templating back in if necessary. Happy to help when this comes up |
related issues (closes acts-project#2792) - acts-project#2792 `autodiff` became more of a burden at some point. Since we do not consistently template all the quantities we might want to derive later this became more of an exception. I propose to remove it for now until we have a broader solution or purpose for it
related issues (closes acts-project#2792) - acts-project#2792 `autodiff` became more of a burden at some point. Since we do not consistently template all the quantities we might want to derive later this became more of an exception. I propose to remove it for now until we have a broader solution or purpose for it
related issues (closes acts-project#2792) - acts-project#2792 `autodiff` became more of a burden at some point. Since we do not consistently template all the quantities we might want to derive later this became more of an exception. I propose to remove it for now until we have a broader solution or purpose for it
related issues (closes #2792)
autodiff
became more of a burden at some point. Since we do not consistently template all the quantities we might want to derive later this became more of an exception. I propose to remove it for now until we have a broader solution or purpose for it