Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: GX2F: write documentation #2803

Merged
merged 16 commits into from
Dec 20, 2023
Merged

Conversation

AJPfleger
Copy link
Contributor

Adds documentation for the Global Chi Square Fitter (GX2F).

As part of the docathon, this will close #2791.

@github-actions github-actions bot added the Component - Documentation Affects the documentation label Dec 11, 2023
@AJPfleger AJPfleger marked this pull request as ready for review December 15, 2023 16:50
@dimitra97
Copy link
Contributor

I added some minor comments mostly for completeness and for my understanding. Apart from that, seems very good!

@AJPfleger AJPfleger requested a review from dimitra97 December 18, 2023 16:43
@AJPfleger AJPfleger added this to the next milestone Dec 20, 2023
@kodiakhq kodiakhq bot merged commit b6c191a into acts-project:main Dec 20, 2023
24 of 37 checks passed
@AJPfleger AJPfleger deleted the docathon-gx2f branch December 20, 2023 14:55
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [b6c191a]

🔴 Some tests have failed!

Please investigate the pipeline!

status job report
🟢 run_unit_tests
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateAmbiguityResolution.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateResolvedTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsGSFRefitting.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🔴 run_workflow_tests_run2_data
🔴 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Dec 20, 2023
@AJPfleger AJPfleger mentioned this pull request Dec 21, 2023
10 tasks
@paulgessinger paulgessinger modified the milestones: next, v32.0.0 Jan 19, 2024
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Jan 23, 2024
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
Adds documentation for the Global Chi Square Fitter (GX2F).

As part of the docathon, this will close acts-project#2791.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Documentation Affects the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write GX2F documentation
4 participants