refactor!: set different initial spatial and temporal vertex variances #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
andiwand
previously approved these changes
Dec 11, 2023
📊: Physics performance monitoring for e353300physmon summary
|
|
time pull looks good |
andiwand
reviewed
Dec 11, 2023
felix-russo
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2804 +/- ##
==========================================
- Coverage 48.62% 48.62% -0.01%
==========================================
Files 480 480
Lines 28019 28019
Branches 13254 13256 +2
==========================================
- Hits 13625 13624 -1
+ Misses 4802 4801 -1
- Partials 9592 9594 +2 ☔ View full report in Codecov by Sentry. |
|
We lose a few vertices: But I think this is a price we can pay for correct pulls! I talked to @paulgessinger and he is willing to make the necessary changes in Athena (thanks!) Should we get this in then? @andiwand |
|
physmon still fails here. |
|
Sorry I had to update the reference |
andiwand
previously approved these changes
Dec 12, 2023
github-actions
bot
added
Infrastructure
|
Nope, still red. |
|
I think the new physmon was not commented yet so I took a previous one. Should be good now, can we try again @paulgessinger @andiwand |
andiwand
approved these changes
Dec 13, 2023
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
acts-project#2804) Due to our choice of units, temporal coordinates live on a different numerical scale than spatial coordinates This should be considered when setting the initial vertex covariance matrix `BREAKING CHANGE:` member variable `looseConstrValue` is replaced by `initialVariances`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to our choice of units, temporal coordinates live on a different numerical scale than spatial coordinates
This should be considered when setting the initial vertex covariance matrix
BREAKING CHANGE:member variablelooseConstrValueis replaced byinitialVariances