Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: PODIO backends don't need to fill dynamic keys #2820

Merged

Conversation

paulgessinger
Copy link
Member

This was an inconsistency due to different parallel developments.

Blocked by:

@paulgessinger paulgessinger added the 🛑 blocked This item is blocked by another item label Dec 12, 2023
@paulgessinger paulgessinger added this to the next milestone Dec 12, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Plugins Affects one or more Plugins Event Data Model labels Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (01f0877) 48.62% compared to head (307b62e) 48.62%.
Report is 1 commits behind head on main.

❗ Current head 307b62e differs from pull request most recent head c9b542e. Consider uploading reports for the commit c9b542e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2820      +/-   ##
==========================================
- Coverage   48.62%   48.62%   -0.01%     
==========================================
  Files         482      480       -2     
  Lines       28034    28033       -1     
  Branches    13263    13263              
==========================================
- Hits        13631    13630       -1     
  Misses       4803     4803              
  Partials     9600     9600              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulgessinger paulgessinger marked this pull request as ready for review December 13, 2023 15:50
@github-actions github-actions bot removed Component - Core Affects the Core module Event Data Model labels Dec 13, 2023
@paulgessinger paulgessinger removed the 🛑 blocked This item is blocked by another item label Dec 13, 2023
This was an inconsistency due to different parallel developments.
@kodiakhq kodiakhq bot merged commit 66c671c into acts-project:main Dec 14, 2023
51 checks passed
@acts-project-service
Copy link
Collaborator

acts-project-service commented Dec 14, 2023

✅ Athena integration test results [66c671c]

✅ All tests successful

status job report
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🟢 run_unit_tests
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateAmbiguityResolution.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateResolvedTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsGSFRefitting.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Dec 14, 2023
paulgessinger added a commit to paulgessinger/acts that referenced this pull request Dec 15, 2023
…t#2820)

This was an inconsistency due to different parallel developments.

Blocked by:
- acts-project#2712
@paulgessinger paulgessinger modified the milestones: next, v32.0.0 Jan 19, 2024
@paulgessinger paulgessinger removed the Breaks Athena build This PR breaks the Athena build label Jan 23, 2024
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
…t#2820)

This was an inconsistency due to different parallel developments.

Blocked by:
- acts-project#2712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Plugins Affects one or more Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants