feat!: Wire time to spacepoints and seeds #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2829 +/- ##
==========================================
+ Coverage 48.84% 48.86% +0.01%
==========================================
Files 491 491
Lines 28529 28532 +3
Branches 13477 13474 -3
==========================================
+ Hits 13936 13942 +6
- Misses 4868 4869 +1
+ Partials 9725 9721 -4 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for bb43441physmon summary
|
This was referenced Dec 15, 2023
paulgessinger
previously approved these changes
Dec 22, 2023
andiwand
changed the title
|
Physmon looks reasonable I think. Some other tests are still failing, otherwise I'd say this is good to go. |
github-actions
bot
added
the
Infrastructure
paulgessinger
approved these changes
Jan 16, 2024
acts-project-service
added
the
Breaks Athena build
paulgessinger
added
Breaks Athena build
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
Currently our spacepoints and seeds do not carry any time information from a potential measurement to the initial track parameters. In this PR I try to wire optional time information originating from the measurement, carried through spacepoints into seeds and finally into initial track params. One caveat is that we use bound parameters in between which cannot tell if time is actually measured or not. My intermediate solution was to rely on the projected covariance entry to be 0 in this case.
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
An initial track parameter covariance is necessary to avoid double counting and to estimate the covariance purely from the measurements. Pulled out of acts-project#2086 to see the individual effects. I added this to the ODD and ITk full chain and our physmon bocked by - acts-project#2829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our spacepoints and seeds do not carry any time information from a potential measurement to the initial track parameters.
In this PR I try to wire optional time information originating from the measurement, carried through spacepoints into seeds and finally into initial track params.
One caveat is that we use bound parameters in between which cannot tell if time is actually measured or not. My intermediate solution was to rely on the projected covariance entry to be 0 in this case.